From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: move dev_priv->suspend around Date: Wed, 12 Mar 2014 16:12:06 +0100 Message-ID: <20140312151206.GL30571@phenom.ffwll.local> References: <1394442185-30509-1-git-send-email-daniel.vetter@ffwll.ch> <87d2hr23kg.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ea0-f177.google.com (mail-ea0-f177.google.com [209.85.215.177]) by gabe.freedesktop.org (Postfix) with ESMTP id 744A9FABF2 for ; Wed, 12 Mar 2014 08:12:11 -0700 (PDT) Received: by mail-ea0-f177.google.com with SMTP id h10so4998226eak.8 for ; Wed, 12 Mar 2014 08:12:10 -0700 (PDT) Content-Disposition: inline In-Reply-To: <87d2hr23kg.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Jani Nikula Cc: Daniel Vetter , Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org On Wed, Mar 12, 2014 at 11:01:35AM +0200, Jani Nikula wrote: > On Mon, 10 Mar 2014, Daniel Vetter wrote: > > When adding new gunk, _always_ think of a good place. Start/end > > usually just means that this didn't happen, and on top of that results > > in needless conflicts with other patches doing the same. > > I'm a fan of unnamed structs within structs to group stuff. The .wm one > in dev priv is a great example. Me too, but I haven't found a suitable companion yet for this stuff ... -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch