From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 1/4] drm/i915: Reduce the time we hold struct mutex in intel_pipe_set_base() Date: Wed, 12 Mar 2014 16:16:24 +0100 Message-ID: <20140312151624.GM30571@phenom.ffwll.local> References: <1394559456-7348-1-git-send-email-ville.syrjala@linux.intel.com> <1394559456-7348-2-git-send-email-ville.syrjala@linux.intel.com> <20140312083241.GF23307@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-ee0-f49.google.com (mail-ee0-f49.google.com [74.125.83.49]) by gabe.freedesktop.org (Postfix) with ESMTP id 812C3F9CE1 for ; Wed, 12 Mar 2014 08:16:29 -0700 (PDT) Received: by mail-ee0-f49.google.com with SMTP id c41so4428553eek.36 for ; Wed, 12 Mar 2014 08:16:28 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20140312083241.GF23307@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Chris Wilson , ville.syrjala@linux.intel.com, intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, Mar 12, 2014 at 08:32:41AM +0000, Chris Wilson wrote: > On Tue, Mar 11, 2014 at 07:37:33PM +0200, ville.syrjala@linux.intel.com w= rote: > > From: Ville Syrj=E4l=E4 > > = > > We don't need to hold struct_mutex all through intel_pipe_set_base(), > > just need to hold it while pinning/unpinning the buffers. > > = > > So reduce the struct_mutext usage in intel_pipe_set_base() just like we > > did for the sprite code in: > > commit 82284b6becdbef6d8cd3fb43e8698510833a5129 > > Author: Ville Syrj=E4l=E4 > > Date: Tue Oct 1 18:02:12 2013 +0300 > > = > > drm/i915: Reduce the time we hold struct mutex in sprite update_pla= ne code > > = > > The FBC and PSR locking is still entirely fubar. That stuff was > > previouly done while holding struct_mutex, so leave it there for now. > = > Yup. I am amazed we enabled FBC when it has known deadlocks... Well I occasional decide to retreat from certain fronts to fighther the bigger war. But I've resolved that any psr/fbc stuff will only be merged enabled by default now. We might need to postpone the locking fixes past merging byt psr though I fear ... > Reviewed-by: Chris Wilson Merged this one here for now, I'll let you two duke it out over the remaining patches ;-) Thanks, Daniel -- = Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch