From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [RFC] Remove cause of 'primary plane already enabled' kernel warning Date: Wed, 12 Mar 2014 18:14:23 +0200 Message-ID: <20140312161423.GI20292@intel.com> References: <1394639710-6540-1-git-send-email-joao.santos@intel.com> <1394639710-6540-2-git-send-email-joao.santos@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id E4E02FB0E1 for ; Wed, 12 Mar 2014 09:15:26 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1394639710-6540-2-git-send-email-joao.santos@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: joao.santos@intel.com Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, Mar 12, 2014 at 03:55:10PM +0000, joao.santos@intel.com wrote: > From: Joao Santos > = > Remove code which is trigerring a kernel warning. The kernel sets the > primary_enable flag prior to calling intel_enable_primary_plane() which a= lso > sets it. This causes the WARN to assert everytime. > = > ------------[ cut here ]------------ > [ 5.458511] WARNING: at i915/intel_display.c:2004 intel_enable_primary= _plane+0xd8/0xe0() > [ 5.458511] Primary plane already enabled > [ 5.458513] Modules linked in: > [ 5.458516] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 3.10.20-263878-g= 086400b #10 > [ 5.458517] Hardware name: Intel Corporation Shark Bay Client platform= /WhiteTip Mountain 1, BIOS HSWLPTU1.86C.0119.R00.1303230105 03/23/2013 > [ 5.458521] ffffffff81d0dbc8 ffff8801488c3378 ffffffff8189d7a4 ffff88= 01488c33b8 > [ 5.458523] ffffffff8105bc60 ffff8801488c33e8 ffff880147118000 000000= 0000000000 > [ 5.458525] 0000000000000000 ffff8801478bc000 ffff880147118000 ffff88= 01488c3418 > = > This patch changes the code to call only intel_enable_primary_plane(). > = > Change-Id: I0fa323e5f5ac330f88a78e7cb2f5ceefeff7d4fd > Signed-off-by: Joao Santos > --- > drivers/gpu/drm/i915/intel_display.c | 4 ---- > 1 file changed, 4 deletions(-) > = > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/= intel_display.c > index ae9b5a1..8953b7c 100644 > --- a/drivers/gpu/drm/i915/intel_display.c > +++ b/drivers/gpu/drm/i915/intel_display.c > @@ -3950,7 +3950,6 @@ static void ironlake_crtc_enable(struct drm_crtc *c= rtc) > */ > intel_crtc_load_lut(crtc); > = > - intel_crtc->primary_enabled =3D true; > intel_update_watermarks(crtc); > intel_enable_pipe(dev_priv, pipe, > intel_crtc->config.has_pch_encoder, false); There's no code like this in the driver. Are you using one of my old WIP watermark branches or something? -- = Ville Syrj=E4l=E4 Intel OTC