From: Daniel Vetter <daniel@ffwll.ch>
To: ville.syrjala@linux.intel.com
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/i915: Unbind all vmas whose new cache_level doesn't agree with the neighbours
Date: Thu, 13 Mar 2014 12:22:59 +0100 [thread overview]
Message-ID: <20140313112258.GP30571@phenom.ffwll.local> (raw)
In-Reply-To: <1394645547-14938-2-git-send-email-ville.syrjala@linux.intel.com>
On Wed, Mar 12, 2014 at 07:32:27PM +0200, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> When we change the cache_level for an object we need to make sure
> we don't put differing types of snoopable memory too close to each
> other on non-LLC machines.
>
> Currently i915_gem_object_set_cache_level() will stop looking when
> it finds just one vma that has such a conflict. Drop the bogus break
> statement to make sure it will unbind all vmas which need to be moved
> around to avoid the conflict.
>
> I suppose this is a theoretical issue as currently we don't enable
> ppgtt on non-LLC machines, so each object can only have one vma.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Both patches merged, thanks.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2014-03-13 11:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-12 17:32 [PATCH 1/2] drm/i915: Drop WARN_ON(flags) from ppgtt_bind_vma() ville.syrjala
2014-03-12 17:32 ` [PATCH 2/2] drm/i915: Unbind all vmas whose new cache_level doesn't agree with the neighbours ville.syrjala
2014-03-13 11:22 ` Daniel Vetter [this message]
2014-03-22 16:59 ` [PATCH 1/2] drm/i915: Drop WARN_ON(flags) from ppgtt_bind_vma() Ben Widawsky
2014-03-22 17:54 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140313112258.GP30571@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox