From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 2/2] drm/i915: Unbind all vmas whose new
 cache_level doesn't agree with the neighbours
Date: Thu, 13 Mar 2014 12:22:59 +0100
Message-ID: <20140313112258.GP30571@phenom.ffwll.local>
References: <1394645547-14938-1-git-send-email-ville.syrjala@linux.intel.com>
	<1394645547-14938-2-git-send-email-ville.syrjala@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-ea0-f173.google.com (mail-ea0-f173.google.com
	[209.85.215.173])
	by gabe.freedesktop.org (Postfix) with ESMTP id 2968FFACC1
	for <intel-gfx@lists.freedesktop.org>;
	Thu, 13 Mar 2014 04:23:05 -0700 (PDT)
Received: by mail-ea0-f173.google.com with SMTP id r15so418177ead.32
	for <intel-gfx@lists.freedesktop.org>;
	Thu, 13 Mar 2014 04:23:04 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1394645547-14938-2-git-send-email-ville.syrjala@linux.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces@lists.freedesktop.org
Errors-To: intel-gfx-bounces@lists.freedesktop.org
To: ville.syrjala@linux.intel.com
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Wed, Mar 12, 2014 at 07:32:27PM +0200, ville.syrjala@linux.intel.com wro=
te:
> From: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
> =

> When we change the cache_level for an object we need to make sure
> we don't put differing types of snoopable memory too close to each
> other on non-LLC machines.
> =

> Currently i915_gem_object_set_cache_level() will stop looking when
> it finds just one vma that has such a conflict. Drop the bogus break
> statement to make sure it will unbind all vmas which need to be moved
> around to avoid the conflict.
> =

> I suppose this is a theoretical issue as currently we don't enable
> ppgtt on non-LLC machines, so each object can only have one vma.
> =

> Signed-off-by: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>

Both patches merged, thanks.
-Daniel
-- =

Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch