From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH] drm/i915: Do not call retire_requests from
 wait_for_rendering
Date: Thu, 13 Mar 2014 13:46:59 +0200
Message-ID: <20140313114659.GN20292@intel.com>
References: <1393008347-441-2-git-send-email-chris@chris-wilson.co.uk>
	<1394629433-4349-1-git-send-email-chris@chris-wilson.co.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
	by gabe.freedesktop.org (Postfix) with ESMTP id BC899FA64C
	for <intel-gfx@lists.freedesktop.org>;
	Thu, 13 Mar 2014 04:47:06 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1394629433-4349-1-git-send-email-chris@chris-wilson.co.uk>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces@lists.freedesktop.org
Errors-To: intel-gfx-bounces@lists.freedesktop.org
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Wed, Mar 12, 2014 at 01:03:53PM +0000, Chris Wilson wrote:
> A common issue we have is that retiring requests causes recursion
> through GTT manipulation or page table manipulation which we can only
> handle at very specific points. However, to maintain internal
> consistency (enforced through our sanity checks on write_domain at
> various points in the GEM object lifecycle) we do need to retire the
> object prior to marking it with a new write_domain, and also clear the
> write_domain for the implicit flush following a batch.
> =

> Note that this then allows the unbound objects to still be on the active
> lists, and so care must be taken when removing objects from unbound lists
> (similar to the caveats we face processing the bound lists).
> =

> v2: Fix i915_gem_shrink_all() to handle updated object lifetime rules,
> by refactoring it to call into __i915_gem_shrink().
> =

> v3: Missed an object-retire prior to changing cache domains in
> i915_gem_object_set_cache_leve()
> =

> v4: Rebase
> =

> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

This can have my
Tested-by: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>

It fixes the vma unbind recursion issues that have plagued my ivb with
full ppgtt as I noted here:
https://bugs.freedesktop.org/show_bug.cgi?id=3D73383#c29

-- =

Ville Syrj=E4l=E4
Intel OTC