public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: "S, Deepak" <deepak.s@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v3 2/3] drm/i915/vlv: WA for Turbo and RC6 to work together.
Date: Thu, 13 Mar 2014 20:57:09 +0200	[thread overview]
Message-ID: <20140313185709.GR20292@intel.com> (raw)
In-Reply-To: <5321FBAD.9010103@intel.com>

On Fri, Mar 14, 2014 at 12:10:45AM +0530, S, Deepak wrote:
> 
> 
> On 3/13/2014 11:47 PM, Ville Syrjälä wrote:
> > On Thu, Mar 13, 2014 at 09:30:17PM +0530, deepak.s@linux.intel.com wrote:
<snip>
> >> @@ -5019,13 +5026,17 @@ enum punit_power_well {
> >>
> >>   #define GEN6_GT_GFX_RC6_LOCKED			0x138104
> >>   #define VLV_COUNTER_CONTROL			0x138104
> >> +#define VLV_RC_COUNTER_CONTROL                  0xFFFF00FF
> >
> > I'd still like to see names for all the bits we frob, and I'd
> > still like to have some kind of an answer to the question whether
> > we really need to enable them all when the w/a is only interested
> > in the rc0 counters.
> 
> I did try with enabling only the rc0 counters, but the busyness 
> calculation was not right. Let me do some more investigation and get 
> back to you on this.

Well, if you tried it and it didn't work right, then I'm already fairly
satisfied with that. It just needs a comment to make it clear why we
enable them all. Of course if you can dig out more details, that's
always a bonus.

-- 
Ville Syrjälä
Intel OTC

  reply	other threads:[~2014-03-13 18:57 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-03  6:05 [PATCH v2] drm/i915/vlv: WA for Turbo and RC6 to work together deepak.s
2014-03-04 14:20 ` S, Deepak
2014-03-05 12:11 ` Ville Syrjälä
2014-03-05 12:30   ` S, Deepak
2014-03-13 16:00     ` [PATCH v3 0/3] " deepak.s
2014-03-13 16:00       ` [PATCH 1/3] drm/i915: Track the enabled PM interrupts in dev_priv deepak.s
2014-03-13 18:16         ` Ville Syrjälä
2014-03-13 18:43           ` S, Deepak
2014-03-13 18:59             ` Ville Syrjälä
2014-03-15 14:53               ` [PATCH v4 0/3] WA for Turbo and RC6 to work together deepak.s
2014-03-15 14:53                 ` [PATCH v2 1/3] drm/i915: Track the enabled PM interrupts in dev_priv deepak.s
2014-03-24 19:26                   ` Ville Syrjälä
2014-03-24 20:22                     ` Daniel Vetter
2014-03-15 14:53                 ` [PATCH v4 2/3] drm/i915/vlv: WA for Turbo and RC6 to work together deepak.s
2014-03-24 19:26                   ` Ville Syrjälä
2014-03-15 14:53                 ` [PATCH v3 3/3] drm/i915: Add boot paramter to control rps boost at boot time deepak.s
2014-03-24 19:27                   ` Ville Syrjälä
2014-03-27  6:35                 ` [PATCH v5] drm/i915/vlv: WA for Turbo and RC6 to work together deepak.s
2014-03-28 12:53                   ` Ville Syrjälä
2014-03-28 13:06                     ` Chris Wilson
2014-03-30  6:27                       ` Deepak S
2014-03-30  6:28                   ` [PATCH v6] " deepak.s
2014-05-13 22:12                     ` Jesse Barnes
2014-03-13 16:00       ` [PATCH v3 2/3] " deepak.s
2014-03-13 18:17         ` Ville Syrjälä
2014-03-13 18:40           ` S, Deepak
2014-03-13 18:57             ` Ville Syrjälä [this message]
2014-03-13 16:00       ` [PATCH v2 3/3] drm/i915: Add boot paramter to control rps boost at boot time deepak.s
2014-03-13 18:16         ` Ville Syrjälä
2014-03-13 18:46           ` S, Deepak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140313185709.GR20292@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=deepak.s@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox