From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Widawsky <ben@bwidawsk.net>
Subject: Re: [PATCH] intel_audio_dump: fix CTS/M value index
Date: Fri, 14 Mar 2014 23:07:35 -0700
Message-ID: <20140315060734.GA17690@bwidawsk.net>
References: <1212523efe55f7fae8bf968587837e9f392fe985.1394663349.git.mengdong.lin@intel.com>
 <1394761443.18219.170.camel@xhh-ivb32>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail.bwidawsk.net (bwidawsk.net [166.78.191.112])
 by gabe.freedesktop.org (Postfix) with ESMTP id 81D5989272
 for <intel-gfx@lists.freedesktop.org>; Sat, 15 Mar 2014 02:43:34 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1394761443.18219.170.camel@xhh-ivb32>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: "Xiang, Haihao" <haihao.xiang@intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Fri, Mar 14, 2014 at 09:44:03AM +0800, Xiang, Haihao wrote:
> On Thu, 2014-03-13 at 16:38 -0400, mengdong.lin@intel.com wrote: 
> > From: Mengdong Lin <mengdong.lin@intel.com>
> > 
> > This patch fixes the reversed CTS/M value index when dumping the
> > 'audio M/CTS programing enable' register.
> > 
> > Signed-off-by: Mengdong Lin <mengdong.lin@intel.com>
> > 
> > diff --git a/tools/intel_audio_dump.c b/tools/intel_audio_dump.c
> > index 46eebdb..3ed2918 100644
> > --- a/tools/intel_audio_dump.c
> > +++ b/tools/intel_audio_dump.c
> > @@ -97,6 +97,11 @@ static int get_num_pipes(void)
> >  	return num_pipes;
> >  }
> >  
> > +static const char * const cts_m_value_index[] = {
> > +	[0] = "CTS",
> > +	[1] = "M",
> > +};
> > +
> >  static const char * const pixel_clock[] = {
> >  	[0] = "25.2 / 1.001 MHz",
> >  	[1] = "25.2 MHz",
> > @@ -1408,7 +1413,8 @@ static void dump_aud_m_cts_enable(int index)
> >  
> >  	printf("%s  CTS_programming\t\t\t%#lx\n",        prefix, BITS(dword, 19, 0));
> >  	printf("%s  Enable_CTS_or_M_programming\t%lu\n", prefix, BIT(dword, 20));
> > -	printf("%s  CTS_M value Index\t\t\t%s\n",        prefix, BIT(dword, 21) ? "CTS" : "M");
> > +	printf("%s  CTS_M value Index\t\t\t[0x%lx] %s\n",prefix, BIT(dword, 21),
> > +		OPNAME(cts_m_value_index, BIT(dword, 21)));
> >  }
> >  
> >  static void dump_aud_power_state(void)
> 
> It is OK for me.
> Reviewed-by: Haihao Xiang <haihao.xiang@intel.com>

Pushed. Thanks.

-- 
Ben Widawsky, Intel Open Source Technology Center