From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Remove spurious '()' in WARN macros Date: Tue, 18 Mar 2014 10:01:07 +0100 Message-ID: <20140318090107.GY30571@phenom.ffwll.local> References: <1395079188-7279-1-git-send-email-damien.lespiau@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f46.google.com (mail-ee0-f46.google.com [74.125.83.46]) by gabe.freedesktop.org (Postfix) with ESMTP id 430E42B383 for ; Tue, 18 Mar 2014 02:01:11 -0700 (PDT) Received: by mail-ee0-f46.google.com with SMTP id t10so5053805eei.19 for ; Tue, 18 Mar 2014 02:01:10 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1395079188-7279-1-git-send-email-damien.lespiau@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Damien Lespiau Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Mon, Mar 17, 2014 at 05:59:48PM +0000, Damien Lespiau wrote: > No need of any here. > > Signed-off-by: Damien Lespiau Queued for -next, thanks for the patch. -Daniel > --- > drivers/gpu/drm/i915/intel_display.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c > index d34add5..c6743f0 100644 > --- a/drivers/gpu/drm/i915/intel_display.c > +++ b/drivers/gpu/drm/i915/intel_display.c > @@ -1166,7 +1166,7 @@ static void assert_planes_disabled(struct drm_i915_private *dev_priv, > if (INTEL_INFO(dev)->gen >= 4) { > reg = DSPCNTR(pipe); > val = I915_READ(reg); > - WARN((val & DISPLAY_PLANE_ENABLE), > + WARN(val & DISPLAY_PLANE_ENABLE, > "plane %c assertion failure, should be disabled but not\n", > plane_name(pipe)); > return; > @@ -1195,20 +1195,20 @@ static void assert_sprites_disabled(struct drm_i915_private *dev_priv, > for_each_sprite(pipe, sprite) { > reg = SPCNTR(pipe, sprite); > val = I915_READ(reg); > - WARN((val & SP_ENABLE), > + WARN(val & SP_ENABLE, > "sprite %c assertion failure, should be off on pipe %c but is still active\n", > sprite_name(pipe, sprite), pipe_name(pipe)); > } > } else if (INTEL_INFO(dev)->gen >= 7) { > reg = SPRCTL(pipe); > val = I915_READ(reg); > - WARN((val & SPRITE_ENABLE), > + WARN(val & SPRITE_ENABLE, > "sprite %c assertion failure, should be off on pipe %c but is still active\n", > plane_name(pipe), pipe_name(pipe)); > } else if (INTEL_INFO(dev)->gen >= 5) { > reg = DVSCNTR(pipe); > val = I915_READ(reg); > - WARN((val & DVS_ENABLE), > + WARN(val & DVS_ENABLE, > "sprite %c assertion failure, should be off on pipe %c but is still active\n", > plane_name(pipe), pipe_name(pipe)); > } > -- > 1.8.3.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch