Re: [PATCH 2/2] drm/i915: Print how many objects are shared in per-process statsg

Daniel Vetter
2014-03-20T14:11:26Z

On Thu, Mar 20, 2014 at 07:40:37AM +0000, Chris Wilson wrote:
> On Wed, Mar 19, 2014 at 09:42:49PM -0700, Ben Widawsky wrote:
> > On Wed, Mar 19, 2014 at 01:45:46PM +0000, Chris Wilson wrote:
> > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> >
> > Any clue how you intend to use this for a commit message (I'm actually
> > curious)? Also, the subject is wrong, you're counting size, not
> > quantity. Anyhoo, looks correct.
>
> Knowing how much of the allocated objects are shared between processes
> helps gauge whether a process is leaking private objects, or if it
> simply a display server suffering memory pressure from lots of clients.

I've added something along these lines here.
>
> > Reviewed-by: Ben Widawsky <ben@bwidawsk.net>

Both patches merged, thanks.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch