Re: [PATCH 2/2] drm/i915: Print how many objects are shared in per-process statsg

Chris Wilson
2014-03-20T07:40:41Z

On Wed, Mar 19, 2014 at 09:42:49PM -0700, Ben Widawsky wrote:
> On Wed, Mar 19, 2014 at 01:45:46PM +0000, Chris Wilson wrote:
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>
> Any clue how you intend to use this for a commit message (I'm actually
> curious)? Also, the subject is wrong, you're counting size, not
> quantity. Anyhoo, looks correct.

Knowing how much of the allocated objects are shared between processes
helps gauge whether a process is leaking private objects, or if it
simply a display server suffering memory pressure from lots of clients.

> Reviewed-by: Ben Widawsky <ben@bwidawsk.net>

--
Chris Wilson, Intel Open Source Technology Centre