From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Add a DRM property "psr" Date: Wed, 19 Mar 2014 09:44:38 +0100 Message-ID: <20140319084438.GM30571@phenom.ffwll.local> References: <1395172267-9203-1-git-send-email-sivachandra@chromium.org> <20140318130620.07fa8680@jbarnes-desktop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f49.google.com (mail-ee0-f49.google.com [74.125.83.49]) by gabe.freedesktop.org (Postfix) with ESMTP id 3B8816E31A for ; Wed, 19 Mar 2014 01:44:44 -0700 (PDT) Received: by mail-ee0-f49.google.com with SMTP id c41so6227912eek.22 for ; Wed, 19 Mar 2014 01:44:42 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Siva Chandra Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Mar 18, 2014 at 01:53:56PM -0700, Siva Chandra wrote: > On Tue, Mar 18, 2014 at 1:06 PM, Jesse Barnes wrote: > > On Tue, 18 Mar 2014 12:51:07 -0700 > > Siva Chandra wrote: > > > >> This property helps one turn PSR "on" and "off" via xrandr. > >> The default value is same as that of the module param i915.enable_psr. > >> > >> Signed-off-by: Siva Chandra > >> --- > > > > So are you using this in Chromium for disabling PSR in cases where it > > doesn't work? Or to optimize power consumption when the kernel driver > > gets it wrong? Or just for debug? > > We are testing a few PSR panels; Having a knob to turn PSR on and off > would be of great convenience for manual testing and for test scripts. Is the module param not good enough for that? Iirc we recheck that every time ... -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch