Re: [PATCH] drm/i915: Add a DRM property "psr"

Siva Chandra
2014-03-19T17:04:15Z

On Wed, Mar 19, 2014 at 8:03 AM, Damien Lespiau
<damien.lespiau@intel.com> wrote:
> On Wed, Mar 19, 2014 at 09:44:38AM +0100, Daniel Vetter wrote:
>> On Tue, Mar 18, 2014 at 01:53:56PM -0700, Siva Chandra wrote:
>> > We are testing a few PSR panels; Having a knob to turn PSR on and off
>> > would be of great convenience for manual testing and for test scripts.
>>
>> Is the module param not good enough for that? Iirc we recheck that every
>> time ...
>
> (the module parameter is accessible through a file in sysfs:
> /sys/module/i915/parameters/enable_psr)

As I mentioned in the other mail, this param is not active and I
couldn't think of any neat solution to make it active.

> Alternatively, doesn't it look like something that belongs to debugfs?
> ie not an API with a stability guarantee?

PSR is part of the eDP standard now. Also, we are only bringing in an
on/off knob. Is really going to cause us stability issues?

Thanks,
Siva Chandra