Re: [PATCH] drm/i915: Add a DRM property "psr"

Siva Chandra
2014-03-21T21:10:17Z

On Thu, Mar 20, 2014 at 7:49 AM, Jani Nikula
<jani.nikula@linux.intel.com> wrote:
> echo 1 > /sys/module/i915/parameters/enable_psr
> echo something > sys/kernel/debug/dri/0/i915_edp_psr_update
>
> where that debugfs file essentially calls intel_edp_psr_update() on
> update.
>
> I guess it could be i915_edp_psr_enable and echoing there would modify
> the module parameter and call update.

I am OK with this, but your last sentence is confusing. If echoing to
the debugfs file modifies the module param, why is the echo to the
module param required at all?

One last note before I stop dragging this thread: We are dealing with
few panels which support PSR but in non-standard ways. So, we will
likely use this knob for PSR control beyond just testing. While I am
OK with debugfs, I would prefer to have a more standard way. Do you
think debugfs is the best place to keep this knob?

Thanks,
Siva Chandra