From: Daniel Vetter <daniel@ffwll.ch>
To: Timo Aaltonen <timo.aaltonen@canonical.com>
Cc: Intel GFX <intel-gfx@lists.freedesktop.org>,
Ben Widawsky <benjamin.widawsky@intel.com>
Subject: Re: [PATCH] drm/i915/bdw: Restore PPAT on thaw
Date: Wed, 19 Mar 2014 09:47:44 +0100 [thread overview]
Message-ID: <20140319084744.GN30571@phenom.ffwll.local> (raw)
In-Reply-To: <532957A7.6030703@canonical.com>
On Wed, Mar 19, 2014 at 10:39:03AM +0200, Timo Aaltonen wrote:
> On 19.03.2014 01:09, Ben Widawsky wrote:
> > Apparently it is wiped out from under us, and we get some really fun
> > caching artifacts upon resume (it seems to be WB for all types by
> > default).
> >
> > Reported-by: James Ausmus <james.ausmus@intel.com>
> > Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
>
> Excellent!
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=76113
> Tested-by: Timo Aaltonen <timo.aaltonen@canonical.com>
Also Cc: stable@vger.kernel.org
Queued for -next, thanks for the patch.
-Daniel
>
> > ---
> > drivers/gpu/drm/i915/i915_gem_gtt.c | 6 +++++-
> > 1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
> > index bd016e2..1b45a04 100644
> > --- a/drivers/gpu/drm/i915/i915_gem_gtt.c
> > +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
> > @@ -30,6 +30,8 @@
> > #include "i915_trace.h"
> > #include "intel_drv.h"
> >
> > +static void gen8_setup_private_ppat(struct drm_i915_private *dev_priv);
> > +
> > bool intel_enable_ppgtt(struct drm_device *dev, bool full)
> > {
> > if (i915.enable_ppgtt == 0 || !HAS_ALIASING_PPGTT(dev))
> > @@ -1371,8 +1373,10 @@ void i915_gem_restore_gtt_mappings(struct drm_device *dev)
> > }
> >
> >
> > - if (INTEL_INFO(dev)->gen >= 8)
> > + if (INTEL_INFO(dev)->gen >= 8) {
> > + gen8_setup_private_ppat(dev_priv);
> > return;
> > + }
> >
> > list_for_each_entry(vm, &dev_priv->vm_list, global_link) {
> > /* TODO: Perhaps it shouldn't be gen6 specific */
> >
>
>
> --
> timo.aaltonen@canonical.com
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2014-03-19 8:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-18 23:09 [PATCH] drm/i915/bdw: Restore PPAT on thaw Ben Widawsky
2014-03-19 0:33 ` Ausmus, James
2014-03-19 6:57 ` Chris Wilson
2014-03-19 8:39 ` Timo Aaltonen
2014-03-19 8:47 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140319084744.GN30571@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=benjamin.widawsky@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=timo.aaltonen@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox