From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915/bdw: Restore PPAT on thaw Date: Wed, 19 Mar 2014 09:47:44 +0100 Message-ID: <20140319084744.GN30571@phenom.ffwll.local> References: <1395184177-10673-1-git-send-email-benjamin.widawsky@intel.com> <532957A7.6030703@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f50.google.com (mail-ee0-f50.google.com [74.125.83.50]) by gabe.freedesktop.org (Postfix) with ESMTP id D16D16E982 for ; Wed, 19 Mar 2014 01:47:49 -0700 (PDT) Received: by mail-ee0-f50.google.com with SMTP id c13so6244454eek.37 for ; Wed, 19 Mar 2014 01:47:47 -0700 (PDT) Content-Disposition: inline In-Reply-To: <532957A7.6030703@canonical.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Timo Aaltonen Cc: Intel GFX , Ben Widawsky List-Id: intel-gfx@lists.freedesktop.org On Wed, Mar 19, 2014 at 10:39:03AM +0200, Timo Aaltonen wrote: > On 19.03.2014 01:09, Ben Widawsky wrote: > > Apparently it is wiped out from under us, and we get some really fun > > caching artifacts upon resume (it seems to be WB for all types by > > default). > > > > Reported-by: James Ausmus > > Signed-off-by: Ben Widawsky > > Excellent! > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=76113 > Tested-by: Timo Aaltonen Also Cc: stable@vger.kernel.org Queued for -next, thanks for the patch. -Daniel > > > --- > > drivers/gpu/drm/i915/i915_gem_gtt.c | 6 +++++- > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c > > index bd016e2..1b45a04 100644 > > --- a/drivers/gpu/drm/i915/i915_gem_gtt.c > > +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c > > @@ -30,6 +30,8 @@ > > #include "i915_trace.h" > > #include "intel_drv.h" > > > > +static void gen8_setup_private_ppat(struct drm_i915_private *dev_priv); > > + > > bool intel_enable_ppgtt(struct drm_device *dev, bool full) > > { > > if (i915.enable_ppgtt == 0 || !HAS_ALIASING_PPGTT(dev)) > > @@ -1371,8 +1373,10 @@ void i915_gem_restore_gtt_mappings(struct drm_device *dev) > > } > > > > > > - if (INTEL_INFO(dev)->gen >= 8) > > + if (INTEL_INFO(dev)->gen >= 8) { > > + gen8_setup_private_ppat(dev_priv); > > return; > > + } > > > > list_for_each_entry(vm, &dev_priv->vm_list, global_link) { > > /* TODO: Perhaps it shouldn't be gen6 specific */ > > > > > -- > timo.aaltonen@canonical.com > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch