From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 2/2] drm/i915: Print how many objects are
 shared in per-process statsg
Date: Thu, 20 Mar 2014 15:11:22 +0100
Message-ID: <20140320141122.GO30571@phenom.ffwll.local>
References: <20140319065520.GC20605@nuc-i3427.alporthouse.com>
 <1395236746-15093-1-git-send-email-chris@chris-wilson.co.uk>
 <1395236746-15093-2-git-send-email-chris@chris-wilson.co.uk>
 <20140320044248.GB1748@bwidawsk.net>
 <20140320074037.GL4890@nuc-i3427.alporthouse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-ee0-f51.google.com (mail-ee0-f51.google.com [74.125.83.51])
 by gabe.freedesktop.org (Postfix) with ESMTP id E6DF06E0A5
 for <intel-gfx@lists.freedesktop.org>; Thu, 20 Mar 2014 07:11:26 -0700 (PDT)
Received: by mail-ee0-f51.google.com with SMTP id c13so716956eek.10
 for <intel-gfx@lists.freedesktop.org>; Thu, 20 Mar 2014 07:11:26 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20140320074037.GL4890@nuc-i3427.alporthouse.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>, Ben Widawsky <ben@bwidawsk.net>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Thu, Mar 20, 2014 at 07:40:37AM +0000, Chris Wilson wrote:
> On Wed, Mar 19, 2014 at 09:42:49PM -0700, Ben Widawsky wrote:
> > On Wed, Mar 19, 2014 at 01:45:46PM +0000, Chris Wilson wrote:
> > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > 
> > Any clue how you intend to use this for a commit message (I'm actually
> > curious)? Also, the subject is wrong, you're counting size, not
> > quantity. Anyhoo, looks correct.
> 
> Knowing how much of the allocated objects are shared between processes
> helps gauge whether a process is leaking private objects, or if it
> simply a display server suffering memory pressure from lots of clients.

I've added something along these lines here.
> 
> > Reviewed-by: Ben Widawsky <ben@bwidawsk.net>

Both patches merged, thanks.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch