From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] prime_mmap: Add new test for calling mmap() on dma-buf fds Date: Thu, 20 Mar 2014 16:08:29 +0100 Message-ID: <20140320150829.GP30571@phenom.ffwll.local> References: <1395085415-31292-1-git-send-email-robert.bradford@intel.com> <20140320043135.GA1748@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f54.google.com (mail-ee0-f54.google.com [74.125.83.54]) by gabe.freedesktop.org (Postfix) with ESMTP id 76A766E0D5 for ; Thu, 20 Mar 2014 08:08:34 -0700 (PDT) Received: by mail-ee0-f54.google.com with SMTP id d49so784978eek.27 for ; Thu, 20 Mar 2014 08:08:33 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20140320043135.GA1748@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ben Widawsky Cc: intel-gfx@lists.freedesktop.org, Rob Bradford List-Id: intel-gfx@lists.freedesktop.org On Wed, Mar 19, 2014 at 09:31:35PM -0700, Ben Widawsky wrote: > On Mon, Mar 17, 2014 at 07:43:35PM +0000, Rob Bradford wrote: [snip] > lgtm. Put the commit message in the test description and call it > Reviewed-by: Ben Widawsky igt_assert_cmpint is a useful one, especially for checking failures ;-) But yeah, lgtm too please push. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch