From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH] drm/i915: Add a DRM property "psr"
Date: Thu, 20 Mar 2014 17:16:36 +0200
Message-ID: <20140320151636.GE21652@intel.com>
References: <20140318130620.07fa8680@jbarnes-desktop>
 <CAGyQ6gzRPNRpCDHWLL3P6_+E52v2XjZuOfNOqrQ-=Zvc5aOPCA@mail.gmail.com>
 <20140319084438.GM30571@phenom.ffwll.local>
 <20140319150338.GA27717@strange.amr.corp.intel.com>
 <CAGyQ6gyeBXtrM88tBFZm00UMP+8yH2SRdUA4yWDhGYUGZy6mhw@mail.gmail.com>
 <87r45xw3a0.fsf@intel.com>
 <CAGyQ6gymV9m7KL4ect++psOY3_tqRwGoGxknDP5bBU06fmp80g@mail.gmail.com>
 <87a9cl2e8w.fsf@intel.com>
 <CAGyQ6gzWNo_NDbG-M7jUfU-AuZCBaXcyT-M4vJE-8QMQe+iUxA@mail.gmail.com>
 <87vbv90vt1.fsf@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by gabe.freedesktop.org (Postfix) with ESMTP id 814CA6E0C9
 for <intel-gfx@lists.freedesktop.org>; Thu, 20 Mar 2014 08:19:33 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <87vbv90vt1.fsf@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Thu, Mar 20, 2014 at 04:49:30PM +0200, Jani Nikula wrote:
> On Thu, 20 Mar 2014, Siva Chandra <sivachandra@google.com> wrote:
> > On Thu, Mar 20, 2014 at 6:25 AM, Jani Nikula
> > <jani.nikula@linux.intel.com> wrote:
> >> On Thu, 20 Mar 2014, Siva Chandra <sivachandra@google.com> wrote:
> >>> On Thu, Mar 20, 2014 at 3:52 AM, Jani Nikula
> >>> <jani.nikula@linux.intel.com> wrote:
> >>>> If this is for testing only, and the module parameter does not quite=
 cut
> >>>> it, please add it to debugfs. That we can pretty much change at will.
> >>>
> >>> If I understand correctly, you are suggesting that the on/off knob
> >>> live in debugfs. So, should the module param in sysfs mirror this
> >>> debugfs knob?
> >>
> >> I guess the simplest thing to move forward would be something to update
> >> psr state after the module parameter has been changed, although it's
> >> perhaps a bit clumsy to use.
> >
> > Couldn't understand. May be an example to illustrate what you are sayin=
g?
> =

> echo 1 > /sys/module/i915/parameters/enable_psr
> echo something > sys/kernel/debug/dri/0/i915_edp_psr_update
> =

> where that debugfs file essentially calls intel_edp_psr_update() on
> update.
> =

> I guess it could be i915_edp_psr_enable and echoing there would modify
> the module parameter and call update. With debugfs I'm not so fussy.

Whatever the interface I think it might be nice to allow you to force
the mode of PSR operation (main link off vs. standby).

-- =

Ville Syrj=E4l=E4
Intel OTC