From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/i915: Fix unsafe loop iteration over
 vma whilst unbinding them
Date: Fri, 21 Mar 2014 16:12:39 +0100
Message-ID: <20140321151239.GD30571@phenom.ffwll.local>
References: <1395387656-12212-1-git-send-email-chris@chris-wilson.co.uk>
 <20140321075158.GC5419@nuc-i3427.alporthouse.com>
 <20140321095723.GY30571@phenom.ffwll.local>
 <874n2rq03n.fsf@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-ee0-f51.google.com (mail-ee0-f51.google.com [74.125.83.51])
 by gabe.freedesktop.org (Postfix) with ESMTP id 0BE076E371
 for <intel-gfx@lists.freedesktop.org>; Fri, 21 Mar 2014 08:12:43 -0700 (PDT)
Received: by mail-ee0-f51.google.com with SMTP id c13so1917955eek.38
 for <intel-gfx@lists.freedesktop.org>; Fri, 21 Mar 2014 08:12:43 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <874n2rq03n.fsf@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org, Ben Widawsky <ben@bwidawsk.net>
List-Id: intel-gfx@lists.freedesktop.org

On Fri, Mar 21, 2014 at 01:09:48PM +0200, Jani Nikula wrote:
> On Fri, 21 Mar 2014, Daniel Vetter <daniel@ffwll.ch> wrote:
> > On Fri, Mar 21, 2014 at 07:51:58AM +0000, Chris Wilson wrote:
> >> On Fri, Mar 21, 2014 at 07:40:56AM +0000, Chris Wilson wrote:
> >> > On non-LLC platforms, when changing the cache level of an object, we may
> >> > need to unbind it show that prefetching across page boundaries does not
> >> s/show/so/
> >> > cross into a different memory domain. This requires us to unbind
> >> > conflicting vma, but we did so was iterating over the objects vma in an
> >> s/was//
> >> > unsafe manner (as the list was being modified as we iterated).
> >> 
> >> Coffee will kick in in about 5 minutes.
> >
> > Fixed and applied, thanks for the patch.
> 
> Given the regression was introduced in v3.12 I thought this would've
> been fixes & cc: stable.

Oops, thanks for catching this. cc: stable added. My Linus weather forcast
tells me that -fixes is closed for 3.14 already, so dinq is good enough.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch