public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding@gmail.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
	DRI Development <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 1/2] drm/crtc-helper: fix locking for drm_helper_disable_unused_functions
Date: Fri, 21 Mar 2014 18:01:53 +0100	[thread overview]
Message-ID: <20140321170151.GA6315@ulmo> (raw)
In-Reply-To: <1395321995-4627-1-git-send-email-daniel.vetter@ffwll.ch>


[-- Attachment #1.1: Type: text/plain, Size: 419 bytes --]

On Thu, Mar 20, 2014 at 02:26:34PM +0100, Daniel Vetter wrote:
[...]
> The right fix therefore is to split this helper into an internal and
> external version and add the required locking to the function exported
> to drivers.
> 
> This remedies locking inconsistencies exposed by me adding locking
> WARNs as part of the recent kerneldoc abi polishing done in

Tested-by: Thierry Reding <treding@nvidia.com>

[-- Attachment #1.2: Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

      parent reply	other threads:[~2014-03-21 17:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-20 13:01 [PATCH 1/2] drm/crtc-helper: fix locking for drm_helper_disable_unused_functions Daniel Vetter
2014-03-20 13:01 ` [PATCH 2/2] drm/fb-helper: improve drm_fb_helper_initial_config locking Daniel Vetter
2014-03-20 13:06 ` [PATCH 1/2] drm/crtc-helper: fix locking for drm_helper_disable_unused_functions Chris Wilson
2014-03-20 13:26   ` Daniel Vetter
2014-03-20 13:26     ` [PATCH 2/2] drm/fb-helper: improve drm_fb_helper_initial_config locking Daniel Vetter
2014-03-21 17:02       ` Thierry Reding
2014-03-20 13:34     ` [PATCH 1/2] drm/crtc-helper: fix locking for drm_helper_disable_unused_functions Chris Wilson
2014-03-21 17:01     ` Thierry Reding [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140321170151.GA6315@ulmo \
    --to=thierry.reding@gmail.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox