From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Rename GFX_TLB_INVALIDATE_ALWAYS Date: Sat, 22 Mar 2014 12:23:56 +0100 Message-ID: <20140322112356.GD26519@phenom.ffwll.local> References: <1395422334-23544-1-git-send-email-chris@chris-wilson.co.uk> <1395458987.19358.53.camel@sourabgu-desktop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f45.google.com (mail-ee0-f45.google.com [74.125.83.45]) by gabe.freedesktop.org (Postfix) with ESMTP id EA7D06E4F9 for ; Sat, 22 Mar 2014 04:24:01 -0700 (PDT) Received: by mail-ee0-f45.google.com with SMTP id d17so2652425eek.18 for ; Sat, 22 Mar 2014 04:24:01 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1395458987.19358.53.camel@sourabgu-desktop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Gupta, Sourab" Cc: "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org On Sat, Mar 22, 2014 at 03:29:11AM +0000, Gupta, Sourab wrote: > On Fri, 2014-03-21 at 17:18 +0000, Chris Wilson wrote: > > The documentation calls this GFX_MODE bit "Flush TLB invalidate Mode". > > However, that is not a good name for an enable bit as it doesn't make it > > clear what is enabled. An even worse name is GFX_TLB_INVALIDATE_ALWAYS > > as enabling that bit actually prevents the TLB from being invalidated at > > every flush. This leads to great confusion when reading code and > > proposed patches. To get around this try to bake in what is enabled by > > setting the bit and call it GFX_TLB_INVALIDATE_EXPLICIT. > > > > This looks fine. It clears the confusion around TLB INVALIDATE Bit. > We'll be developing our patch on top of this and sending the full series > of WA patches for VLV. btw if you think the patch is useful and you've reviewed it according to the "Reviewer's Statement of Oversight" [1] then please always supply your reviewed-by tag. Otherwise it's just the informal acked-by. Patch merged into dinq. Thanks, Daniel [1] https://www.kernel.org/doc/Documentation/SubmittingPatches -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch