Re: [PATCH 1/2] drm/i915: Drop WARN_ON(flags) from ppgtt_bind_vma()

[Daniel Vetter <daniel@ffwll.ch>]

On Sat, Mar 22, 2014 at 09:59:50AM -0700, Ben Widawsky wrote:
> On Wed, Mar 12, 2014 at 07:32:26PM +0200, ville.syrjala@linux.intel.com wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > 
> > We will call ppgtt_bind_vma() with flags != 0, so the WARN_ON(flags)
> > is bogus. Kill it.
> > 
> 
> This is not an appropriate commit message to change an invariant. The
> case was true, and it apparently no longer holds. At the very least the
> commit should have the SHA which changed the invariant, and preferably
> an explanation as to why the invariant no longer holds ("is bogus"). I
> 
> The reason you have given to remove this WARN_ON can be used for any
> assertion we ever hit and simply reiterates what the patch does.

I agree that the commit message is a bit too thin. Unfortunately I've
already baked in dinq so I can't go back and rectify history :(

Since this patch removes something we also can't fix that by adding a
comment around the new code and supplying the missing commit messages bits
there.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch