From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 1/2] drm/i915: Drop WARN_ON(flags) from
 ppgtt_bind_vma()
Date: Sat, 22 Mar 2014 18:54:41 +0100
Message-ID: <20140322175441.GH26519@phenom.ffwll.local>
References: <1394645547-14938-1-git-send-email-ville.syrjala@linux.intel.com>
 <20140322165950.GA18495@bwidawsk.net>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-ee0-f41.google.com (mail-ee0-f41.google.com [74.125.83.41])
 by gabe.freedesktop.org (Postfix) with ESMTP id BD0816E593
 for <intel-gfx@lists.freedesktop.org>; Sat, 22 Mar 2014 10:54:45 -0700 (PDT)
Received: by mail-ee0-f41.google.com with SMTP id t10so2931712eei.0
 for <intel-gfx@lists.freedesktop.org>; Sat, 22 Mar 2014 10:54:45 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20140322165950.GA18495@bwidawsk.net>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Ben Widawsky <ben@bwidawsk.net>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Sat, Mar 22, 2014 at 09:59:50AM -0700, Ben Widawsky wrote:
> On Wed, Mar 12, 2014 at 07:32:26PM +0200, ville.syrjala@linux.intel.com w=
rote:
> > From: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
> > =

> > We will call ppgtt_bind_vma() with flags !=3D 0, so the WARN_ON(flags)
> > is bogus. Kill it.
> > =

> =

> This is not an appropriate commit message to change an invariant. The
> case was true, and it apparently no longer holds. At the very least the
> commit should have the SHA which changed the invariant, and preferably
> an explanation as to why the invariant no longer holds ("is bogus"). I
> =

> The reason you have given to remove this WARN_ON can be used for any
> assertion we ever hit and simply reiterates what the patch does.

I agree that the commit message is a bit too thin. Unfortunately I've
already baked in dinq so I can't go back and rectify history :(

Since this patch removes something we also can't fix that by adding a
comment around the new code and supplying the missing commit messages bits
there.
-Daniel
-- =

Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch