From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Widawsky <ben@bwidawsk.net>
Subject: Re: [PATCH 01/26] drm/i915: Split out verbose PPGTT
 dumping
Date: Sat, 22 Mar 2014 11:13:17 -0700
Message-ID: <20140322181316.GA4929@bwidawsk.net>
References: <1395121738-29126-1-git-send-email-benjamin.widawsky@intel.com>
 <1395121738-29126-2-git-send-email-benjamin.widawsky@intel.com>
 <20140320115742.GA4463@nuc-i3427.alporthouse.com>
 <20140320120800.GB4463@nuc-i3427.alporthouse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail.bwidawsk.net (bwidawsk.net [166.78.191.112])
 by gabe.freedesktop.org (Postfix) with ESMTP id 12B396E59A
 for <intel-gfx@lists.freedesktop.org>; Sat, 22 Mar 2014 11:13:25 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20140320120800.GB4463@nuc-i3427.alporthouse.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>, Ben Widawsky <benjamin.widawsky@intel.com>, Intel GFX <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Thu, Mar 20, 2014 at 12:08:00PM +0000, Chris Wilson wrote:
> On Thu, Mar 20, 2014 at 11:57:42AM +0000, Chris Wilson wrote:
> >  static void gen6_ppgtt_info(struct seq_file *m, struct drm_device *dev, bool verbose)
> > @@ -1838,14 +1841,11 @@ static void gen6_ppgtt_info(struct seq_file *m, struct drm_device *dev, bool ver
> >  
> >  	list_for_each_entry_reverse(file, &dev->filelist, lhead) {
> >  		struct drm_i915_file_private *file_priv = file->driver_priv;
> > -		struct i915_hw_ppgtt *pvt_ppgtt;
> >  
> > -		pvt_ppgtt = ctx_to_ppgtt(file_priv->private_default_ctx);
> >  		seq_printf(m, "proc: %s\n",
> >  			   get_pid_task(file->pid, PIDTYPE_PID)->comm);
> 
> And 
> 	seq_printf(m, "\nproc: %s\n",
> for good measure
> 
> > -		print_ppgtt(m, pvt_ppgtt, "Default context");
> > -		if (verbose)
> > -			idr_for_each(&file_priv->context_idr, per_file_ctx, m);
> > +		idr_for_each(&file_priv->context_idr, per_file_ctx,
> > +			     (void *)((unsigned long)m | verbose));
> >  	}
> >  }
> >  
> > 
> > -- 

Thanks, I like it. I'm assuming you didn't want the count_pt_pages stuck
in at this point (your diff was based on the end result)? I can do that
if you prefer it. It seems pointless to me though.

-- 
Ben Widawsky, Intel Open Source Technology Center