Re: [PATCH 04/12] drm/i915: Rename and comment all the RPS *stuff*

Chris Wilson
2014-03-20T07:01:35Z

On Wed, Mar 19, 2014 at 06:31:11PM -0700, Ben Widawsky wrote:
> The names of the struct members for RPS are stupid. Every time I need to
> do anything in this code I have to spend a significant amount of time to
> remember what it all means. By renaming the variables (and adding the
> comments) I hope to clear up the situation. Indeed doing this make some
> upcoming patches more readable.
>
> I've avoided ILK because it's possible that the naming used for Ironlake
> matches what is in the docs. I believe the ILK power docs were never
> published, and I am too lazy to dig them up.
>
> v2: leave rp0, and rp1 in the names. It is useful to have these limits
> available at times. min_freq and max_freq (which may be equal to rp0, or
> rp1 depending on the platform) represent the actual HW min and max.
>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Ben Widawsky <ben@bwidawsk.net>

I didn't spot any changes that were incorrect, so
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris

--
Chris Wilson, Intel Open Source Technology Centre