From: Ben Widawsky <ben@bwidawsk.net>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Ben Widawsky <benjamin.widawsky@intel.com>,
Intel GFX <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 14/26] drm/i915: Complete page table structures
Date: Sat, 22 Mar 2014 13:10:47 -0700 [thread overview]
Message-ID: <20140322201047.GC18765@bwidawsk.net> (raw)
In-Reply-To: <20140318090945.GE18530@nuc-i3427.alporthouse.com>
On Tue, Mar 18, 2014 at 09:09:45AM +0000, Chris Wilson wrote:
> On Mon, Mar 17, 2014 at 10:48:46PM -0700, Ben Widawsky wrote:
> > Move the remaining members over to the new page table structures.
> >
> > This can be squashed with the previous commit if desire. The reasoning
> > is the same as that patch. I simply felt it is easier to review if split.
>
> I'm not liking the shorter names much. Is there precedence elsewhere
> (e.g. daddr)?
> -Chris
>
I'm not particularly attached to "daddr." It was fun to say in my head.
A lot of code does use "daddr" but it seems to vary between "dma",
"device", data", "destination" Not exactly precedence.
Initially I had the prefix p[td]_daddr, but I thought you might complain
about it because it's implicit. dma_addr seemed kinda redundant to me.
Recommendation?
> --
> Chris Wilson, Intel Open Source Technology Centre
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ben Widawsky, Intel Open Source Technology Center
next prev parent reply other threads:[~2014-03-22 20:11 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-18 5:48 [PATCH 00/26] [RFCish] GEN7 dynamic page tables Ben Widawsky
2014-03-18 5:48 ` [PATCH 01/26] drm/i915: Split out verbose PPGTT dumping Ben Widawsky
2014-03-20 11:57 ` Chris Wilson
2014-03-20 12:08 ` Chris Wilson
2014-03-22 18:13 ` Ben Widawsky
2014-03-22 20:59 ` Chris Wilson
2014-03-18 5:48 ` [PATCH 02/26] drm/i915: Extract switch to default context Ben Widawsky
2014-03-18 8:38 ` Chris Wilson
2014-03-18 5:48 ` [PATCH 03/26] drm/i915: s/pd/pdpe, s/pt/pde Ben Widawsky
2014-03-18 5:48 ` [PATCH 04/26] drm/i915: rename map/unmap to dma_map/unmap Ben Widawsky
2014-03-18 8:40 ` Chris Wilson
2014-03-18 5:48 ` [PATCH 05/26] drm/i915: Setup less PPGTT on failed pagedir Ben Widawsky
2014-03-18 5:48 ` [PATCH 06/26] drm/i915: Wrap VMA binding Ben Widawsky
2014-03-18 8:42 ` Chris Wilson
2014-03-18 5:48 ` [PATCH 07/26] drm/i915: clean up PPGTT init error path Ben Widawsky
2014-03-18 8:44 ` Chris Wilson
2014-03-22 19:43 ` Ben Widawsky
2014-03-22 20:58 ` Chris Wilson
2014-03-23 17:27 ` Ben Widawsky
2014-03-18 5:48 ` [PATCH 08/26] drm/i915: Un-hardcode number of page directories Ben Widawsky
2014-03-18 5:48 ` [PATCH 09/26] drm/i915: Split out gtt specific header file Ben Widawsky
2014-03-18 8:46 ` Chris Wilson
2014-03-18 9:15 ` Daniel Vetter
2014-03-22 19:44 ` Ben Widawsky
2014-03-23 0:46 ` Daniel Vetter
2014-03-18 5:48 ` [PATCH 10/26] drm/i915: Make gen6_write_pdes gen6_map_page_tables Ben Widawsky
2014-03-18 8:48 ` Chris Wilson
2014-03-18 5:48 ` [PATCH 11/26] drm/i915: Range clearing is PPGTT agnostic Ben Widawsky
2014-03-18 8:50 ` Chris Wilson
2014-03-18 5:48 ` [PATCH 12/26] drm/i915: Page table helpers, and define renames Ben Widawsky
2014-03-18 9:05 ` Chris Wilson
2014-03-18 18:29 ` Jesse Barnes
2014-03-19 0:58 ` Ben Widawsky
2014-03-18 5:48 ` [PATCH 13/26] drm/i915: construct page table abstractions Ben Widawsky
2014-03-18 5:48 ` [PATCH 14/26] drm/i915: Complete page table structures Ben Widawsky
2014-03-18 9:09 ` Chris Wilson
2014-03-22 20:10 ` Ben Widawsky [this message]
2014-03-22 21:14 ` Chris Wilson
2014-03-18 5:48 ` [PATCH 15/26] drm/i915: Create page table allocators Ben Widawsky
2014-03-18 9:14 ` Chris Wilson
2014-03-22 20:21 ` Ben Widawsky
2014-03-22 21:10 ` Chris Wilson
2014-03-18 5:48 ` [PATCH 16/26] drm/i915: Generalize GEN6 mapping Ben Widawsky
2014-03-18 9:22 ` Chris Wilson
2014-03-18 5:48 ` [PATCH 17/26] drm/i915: Clean up pagetable DMA map & unmap Ben Widawsky
2014-03-18 9:24 ` Chris Wilson
2014-03-18 5:48 ` [PATCH 18/26] drm/i915: Always dma map page table allocations Ben Widawsky
2014-03-18 9:25 ` Chris Wilson
2014-03-18 5:48 ` [PATCH 19/26] drm/i915: Consolidate dma mappings Ben Widawsky
2014-03-18 9:28 ` Chris Wilson
2014-03-18 5:48 ` [PATCH 20/26] drm/i915: Always dma map page directory allocations Ben Widawsky
2014-03-18 9:29 ` Chris Wilson
2014-03-18 5:48 ` [PATCH 21/26] drm/i915: Track GEN6 page table usage Ben Widawsky
2014-03-18 5:48 ` [PATCH 22/26] drm/i915: Extract context switch skip logic Ben Widawsky
2014-03-18 5:48 ` [PATCH 23/26] drm/i915: Force pd restore when PDEs change, gen6-7 Ben Widawsky
2014-03-18 5:48 ` [PATCH 24/26] drm/i915: Finish gen6/7 dynamic page table allocation Ben Widawsky
2014-03-20 12:15 ` Chris Wilson
2014-03-18 5:48 ` [PATCH 25/26] drm/i915: Print used ppgtt pages for gen6 in debugfs Ben Widawsky
2014-03-20 10:09 ` Chris Wilson
2014-03-20 10:17 ` Chris Wilson
2014-03-18 5:48 ` [PATCH 26/26] FOR REFERENCE ONLY Ben Widawsky
2014-03-20 12:17 ` [PATCH 00/26] [RFCish] GEN7 dynamic page tables Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140322201047.GC18765@bwidawsk.net \
--to=ben@bwidawsk.net \
--cc=benjamin.widawsky@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox