From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v3 3/3] drm/i915: Add boot paramter to control rps boost at boot time. Date: Mon, 24 Mar 2014 21:27:26 +0200 Message-ID: <20140324192726.GL21652@intel.com> References: <20140313185948.GS20292@intel.com> <1394895204-13581-1-git-send-email-deepak.s@linux.intel.com> <1394895204-13581-4-git-send-email-deepak.s@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 5EF3389C98 for ; Mon, 24 Mar 2014 12:27:30 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1394895204-13581-4-git-send-email-deepak.s@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: deepak.s@linux.intel.com Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Sat, Mar 15, 2014 at 08:23:24PM +0530, deepak.s@linux.intel.com wrote: > From: Deepak S > = > We are adding a module paramter to control rps boost. By default, we > enable the boost for better performace. Based on the need (perf/power) > we can either enable/disable. > = > v2: Addressed rps default comment (Jani) > = > v3: Use bool to represent the boot parameter (Ville). > = > Signed-off-by: Deepak S Reviewed-by: Ville Syrj=E4l=E4 > --- > drivers/gpu/drm/i915/i915_drv.h | 1 + > drivers/gpu/drm/i915/i915_gem.c | 2 +- > drivers/gpu/drm/i915/i915_params.c | 5 +++++ > 3 files changed, 7 insertions(+), 1 deletion(-) > = > diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_= drv.h > index f23c258..6d91b1c 100644 > --- a/drivers/gpu/drm/i915/i915_drv.h > +++ b/drivers/gpu/drm/i915/i915_drv.h > @@ -2120,6 +2120,7 @@ struct i915_params { > bool prefault_disable; > bool reset; > bool disable_display; > + bool enable_rps_boost; > }; > extern struct i915_params i915 __read_mostly; > = > diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_= gem.c > index 92b0b41..b9c52b8 100644 > --- a/drivers/gpu/drm/i915/i915_gem.c > +++ b/drivers/gpu/drm/i915/i915_gem.c > @@ -1042,7 +1042,7 @@ static int __wait_seqno(struct intel_ring_buffer *r= ing, u32 seqno, > = > timeout_expire =3D timeout ? jiffies + timespec_to_jiffies_timeout(time= out) : 0; > = > - if (INTEL_INFO(dev)->gen >=3D 6 && can_wait_boost(file_priv)) { > + if (INTEL_INFO(dev)->gen >=3D 6 && can_wait_boost(file_priv) && i915.en= able_rps_boost) { > gen6_rps_boost(dev_priv); > if (file_priv) > mod_delayed_work(dev_priv->wq, > diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i9= 15_params.c > index a66ffb6..772659f 100644 > --- a/drivers/gpu/drm/i915/i915_params.c > +++ b/drivers/gpu/drm/i915/i915_params.c > @@ -49,6 +49,7 @@ struct i915_params i915 __read_mostly =3D { > .invert_brightness =3D 0, > .disable_display =3D 0, > .enable_cmd_parser =3D 0, > + .enable_rps_boost =3D true, > }; > = > module_param_named(modeset, i915.modeset, int, 0400); > @@ -162,3 +163,7 @@ MODULE_PARM_DESC(disable_display, "Disable display (d= efault: false)"); > module_param_named(enable_cmd_parser, i915.enable_cmd_parser, int, 0600); > MODULE_PARM_DESC(enable_cmd_parser, > "Enable command parsing (1=3Denabled, 0=3Ddisabled [default])"); > + > +module_param_named(enable_rps_boost, i915.enable_rps_boost, bool, 0600); > +MODULE_PARM_DESC(enable_rps_boost, > + "Enable/Disable boost RPS frequency (default: true)"); > -- = > 1.8.4.2 > = > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- = Ville Syrj=E4l=E4 Intel OTC