From mboxrd@z Thu Jan 1 00:00:00 1970 From: Damien Lespiau Subject: Re: [PATCH 1/1] drm/i915: Fixing cursor size parameters for wm calculation Date: Tue, 25 Mar 2014 14:50:16 +0000 Message-ID: <20140325145016.GC8248@strange.amr.corp.intel.com> References: <20140324163002.GD12622@strange.icx.intel.com> <1395742596-20235-1-git-send-email-sagar.a.kamble@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id CDE696E0B0 for ; Tue, 25 Mar 2014 07:50:26 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1395742596-20235-1-git-send-email-sagar.a.kamble@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: sagar.a.kamble@intel.com Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Mar 25, 2014 at 03:46:36PM +0530, sagar.a.kamble@intel.com wrote: > From: Sagar Kamble > > Cursor size is changed now take care of larger cursor sizes. > wm calculation was hardcoded to 64 before so changing it. > > Cc: Daniel Vetter > Cc: Jani Nikula > Cc: Damien Lespiau > Signed-off-by: Sagar Kamble > --- > drivers/gpu/drm/i915/intel_pm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c > index ad58ce3..2177e3d 100644 > --- a/drivers/gpu/drm/i915/intel_pm.c > +++ b/drivers/gpu/drm/i915/intel_pm.c > @@ -2120,7 +2120,7 @@ static void ilk_compute_wm_parameters(struct drm_crtc *crtc, > p->pri.bytes_per_pixel = crtc->fb->bits_per_pixel / 8; > p->cur.bytes_per_pixel = 4; > p->pri.horiz_pixels = intel_crtc->config.pipe_src_w; > - p->cur.horiz_pixels = 64; > + p->cur.horiz_pixels = dev->mode_config.cursor_width; Hum? It seems that mode_config.cursor_width is supposed to have the preferred cursor size so a generic DDX (for instance) can select a size that can be used. If we declare 256x256, that generic driver will use a big buffer for the cursor, without any good reason. A previous patch from you doesn't seem to to do that correctly by always setting the max size, we're fine with the default 64x64 (I just sent a patch to address that). Instead of using the DRM cursor_config value the natural thing to do would be to use the actual width being used (sent patch). -- Damien