From mboxrd@z Thu Jan 1 00:00:00 1970 From: Damien Lespiau Subject: Re: [PATCH 1/3] drm/i915: Don't set mode_config's cursor size Date: Tue, 25 Mar 2014 16:05:29 +0000 Message-ID: <20140325160529.GA1729@strange.amr.corp.intel.com> References: <1395758972-31316-1-git-send-email-damien.lespiau@intel.com> <1395758972-31316-2-git-send-email-damien.lespiau@intel.com> <20140325145456.GC1719@nuc-i3427.alporthouse.com> <20140325145918.GD8248@strange.amr.corp.intel.com> <20140325150916.GD1719@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id BC5D16E0E9 for ; Tue, 25 Mar 2014 09:07:13 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20140325150916.GD1719@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org, Sagar Kamble List-Id: intel-gfx@lists.freedesktop.org On Tue, Mar 25, 2014 at 03:09:16PM +0000, Chris Wilson wrote: > On Tue, Mar 25, 2014 at 02:59:18PM +0000, Damien Lespiau wrote: > > On Tue, Mar 25, 2014 at 02:54:56PM +0000, Chris Wilson wrote: > > > On Tue, Mar 25, 2014 at 02:49:30PM +0000, Damien Lespiau wrote: > > > > Those fields are supposed to be a good default value for the cursor > > > > size, intended for the case where the hardware doesn't support 64x64 > > > > cursors, for use with a hw agnostic DDX driver for instance. > > > > > > > > We're fine with 64x64 cursors though and don't need to set those fields > > > > (DRM core will return 64 is we don't). If we declare 256x256, that > > > > generic driver will use a big buffer for the cursor, without any good > > > > reason. > > > > > > How does userspace now know that 256x256 cursors are support for HiDPI? > > > > It doesn't currently? a property on the cursor plane with the list of > > supported formats in the brave new full drm_plane world seems like a > > good option to me. > > Userspace currently uses this method to determine the largest cursor > supported by the driver. That userspace is inept at resize the cursor bo > as required is a probably that won't be solved by simply exposing it > later. That doesn't seem to be the intention of the original patch? http://lists.freedesktop.org/archives/dri-devel/2014-February/053770.html Are you saying the Intel DDX currently derives a different meaning to the intented behaviour? in which case it can still be changed to not do that? -- Damien