From: Damien Lespiau <damien.lespiau@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
intel-gfx@lists.freedesktop.org,
Sagar Kamble <sagar.a.kamble@intel.com>
Subject: Re: [PATCH 1/3] drm/i915: Don't set mode_config's cursor size
Date: Tue, 25 Mar 2014 16:57:04 +0000 [thread overview]
Message-ID: <20140325165704.GD1729@strange.amr.corp.intel.com> (raw)
In-Reply-To: <20140325163824.GG1719@nuc-i3427.alporthouse.com>
On Tue, Mar 25, 2014 at 04:38:24PM +0000, Chris Wilson wrote:
> For the record,
>
> 16:30 < agd5f> ickle, our GPUs don't have selectable cursor sizes
> 16:31 < agd5f> so on the newer ones, xf86-video-modesetting, etc. would
> allocate a 64x64 cursor and it would look squashed and funky since the
> hw expects 128x128
>
> Which means I was confused when I thought part of the reasoning was
> indeed HiDPI support. (I'm still seem to remember that was part of the
> argument for large cursors anyway.)
>
> > Are you saying the Intel DDX currently derives a different meaning to
> > the intented behaviour? in which case it can still be changed to not do
> > that?
>
> I still disagree though. This provides all the information I need to
> support variable sized cursors and we can use large cursors today.
I'd love the game to be about defining clear semantics more than "by
interpreting that value this way, I got what I always wanted" :)
We can resolve that today with MAX_CURSOR_WIDTH, MAX_CURSOR_HEIGHT caps
as well (if you're alluding at the fact that drm_planes may still be a
few decades away).
We'll still need to expose the full list of supported cursor sizes for
compositors at some point or another, my preferred way would be with a
property in the exposed cursor drm_plane.
--
Damien
next prev parent reply other threads:[~2014-03-25 16:58 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-25 14:49 [PATCH 0/3] A few cursor fixups after the multi-size patches Damien Lespiau
2014-03-25 14:49 ` [PATCH 1/3] drm/i915: Don't set mode_config's cursor size Damien Lespiau
2014-03-25 14:54 ` Chris Wilson
2014-03-25 14:59 ` Damien Lespiau
2014-03-25 15:09 ` Chris Wilson
2014-03-25 16:05 ` Damien Lespiau
2014-03-25 16:38 ` Chris Wilson
2014-03-25 16:57 ` Damien Lespiau [this message]
2014-03-25 18:23 ` Daniel Vetter
2014-03-25 18:25 ` Daniel Vetter
2014-03-25 18:51 ` Damien Lespiau
2014-03-25 19:42 ` Daniel Vetter
2014-03-25 17:58 ` Damien Lespiau
2014-03-25 15:15 ` Sagar Arun Kamble
2014-03-25 15:11 ` Imre Deak
2014-03-25 14:49 ` [PATCH 2/3] drm/i915: Remove max_cursor_{width, height} from the crtc Damien Lespiau
2014-03-25 14:49 ` [PATCH 3/3] drm/i915: Use the actual cursor width for WM computation Damien Lespiau
2014-03-26 12:24 ` Chris Wilson
2014-03-26 12:27 ` Chris Wilson
2014-03-26 12:38 ` [PATCH 1/2] drm/i915: Compute WM for current cursor size Chris Wilson
2014-03-26 12:38 ` [PATCH 2/2] drm/i915: Recompute WM when the cursor size changes Chris Wilson
2014-03-26 12:53 ` Daniel Vetter
2014-03-26 15:21 ` Damien Lespiau
2014-03-26 16:35 ` Daniel Vetter
2014-03-26 15:21 ` [PATCH 1/2] drm/i915: Compute WM for current cursor size Damien Lespiau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140325165704.GD1729@strange.amr.corp.intel.com \
--to=damien.lespiau@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=sagar.a.kamble@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox