From: Ben Widawsky <benjamin.widawsky@intel.com>
To: deepak.s@linux.intel.com
Cc: Deepak S <deepak.s@intel.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Match debugfs interface name to new RPS naming
Date: Sun, 30 Mar 2014 12:19:33 -0700 [thread overview]
Message-ID: <20140330191933.GB944@intel.com> (raw)
In-Reply-To: <1396167690-3770-1-git-send-email-deepak.s@linux.intel.com>
On Sun, Mar 30, 2014 at 01:51:30PM +0530, deepak.s@linux.intel.com wrote:
> From: Deepak S <deepak.s@intel.com>
>
> Let's change the i915_cur_delayinfo to i915_cur_freqinfo to be in sync
> with new RPS naming convention.
>
> Signed-off-by: Deepak S <deepak.s@intel.com>
If we're doing a rename, we might as well do a rename. The function does
plenty more than "cur"
my vote:
i915_frequency_info
> ---
> drivers/gpu/drm/i915/i915_debugfs.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> index 049dcb5..3cfc35c 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -966,7 +966,7 @@ static int i915_rstdby_delays(struct seq_file *m, void *unused)
> return 0;
> }
>
> -static int i915_cur_delayinfo(struct seq_file *m, void *unused)
> +static int i915_cur_freqinfo(struct seq_file *m, void *unused)
> {
> struct drm_info_node *node = (struct drm_info_node *) m->private;
> struct drm_device *dev = node->minor->dev;
> @@ -3772,7 +3772,7 @@ static const struct drm_info_list i915_debugfs_list[] = {
> {"i915_gem_hws_bsd", i915_hws_info, 0, (void *)VCS},
> {"i915_gem_hws_vebox", i915_hws_info, 0, (void *)VECS},
> {"i915_rstdby_delays", i915_rstdby_delays, 0},
> - {"i915_cur_delayinfo", i915_cur_delayinfo, 0},
> + {"i915_cur_freqinfo", i915_cur_freqinfo, 0},
> {"i915_delayfreq_table", i915_delayfreq_table, 0},
> {"i915_inttoext_table", i915_inttoext_table, 0},
> {"i915_drpc_info", i915_drpc_info, 0},
> --
> 1.8.5.2
>
--
Ben Widawsky, Intel Open Source Technology Center
next prev parent reply other threads:[~2014-03-30 19:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-30 8:21 [PATCH] drm/i915: Match debugfs interface name to new RPS naming deepak.s
2014-03-30 19:19 ` Ben Widawsky [this message]
2014-03-31 6:00 ` [PATCH v2] " deepak.s
2014-03-31 8:43 ` Daniel Vetter
2014-03-31 18:08 ` Ben Widawsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140330191933.GB944@intel.com \
--to=benjamin.widawsky@intel.com \
--cc=deepak.s@intel.com \
--cc=deepak.s@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox