From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Widawsky <benjamin.widawsky@intel.com>
Subject: Re: [PATCH] drm/i915: Match debugfs interface name to
	new RPS naming
Date: Sun, 30 Mar 2014 12:19:33 -0700
Message-ID: <20140330191933.GB944@intel.com>
References: <1396167690-3770-1-git-send-email-deepak.s@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by gabe.freedesktop.org (Postfix) with ESMTP id 1354E6E10A
 for <intel-gfx@lists.freedesktop.org>; Sun, 30 Mar 2014 12:19:35 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1396167690-3770-1-git-send-email-deepak.s@linux.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: deepak.s@linux.intel.com
Cc: Deepak S <deepak.s@intel.com>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Sun, Mar 30, 2014 at 01:51:30PM +0530, deepak.s@linux.intel.com wrote:
> From: Deepak S <deepak.s@intel.com>
> 
> Let's change the i915_cur_delayinfo to i915_cur_freqinfo to be in sync
> with new RPS naming convention.
> 
> Signed-off-by: Deepak S <deepak.s@intel.com>

If we're doing a rename, we might as well do a rename. The function does
plenty more than "cur"

my vote:
i915_frequency_info

> ---
>  drivers/gpu/drm/i915/i915_debugfs.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> index 049dcb5..3cfc35c 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -966,7 +966,7 @@ static int i915_rstdby_delays(struct seq_file *m, void *unused)
>  	return 0;
>  }
>  
> -static int i915_cur_delayinfo(struct seq_file *m, void *unused)
> +static int i915_cur_freqinfo(struct seq_file *m, void *unused)
>  {
>  	struct drm_info_node *node = (struct drm_info_node *) m->private;
>  	struct drm_device *dev = node->minor->dev;
> @@ -3772,7 +3772,7 @@ static const struct drm_info_list i915_debugfs_list[] = {
>  	{"i915_gem_hws_bsd", i915_hws_info, 0, (void *)VCS},
>  	{"i915_gem_hws_vebox", i915_hws_info, 0, (void *)VECS},
>  	{"i915_rstdby_delays", i915_rstdby_delays, 0},
> -	{"i915_cur_delayinfo", i915_cur_delayinfo, 0},
> +	{"i915_cur_freqinfo", i915_cur_freqinfo, 0},
>  	{"i915_delayfreq_table", i915_delayfreq_table, 0},
>  	{"i915_inttoext_table", i915_inttoext_table, 0},
>  	{"i915_drpc_info", i915_drpc_info, 0},
> -- 
> 1.8.5.2
> 

-- 
Ben Widawsky, Intel Open Source Technology Center