Re: [PATCH 7/7] drm/i915: Use enum plane instaad of numbers

[Daniel Vetter <daniel@ffwll.ch>]

On Mon, Mar 31, 2014 at 07:31:04PM +0200, Daniel Vetter wrote:
> On Mon, Mar 31, 2014 at 06:21:30PM +0300, ville.syrjala@linux.intel.com wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > 
> > Change the update_plane() plane checks to use enum plane, and
> > also fix up the error message to say something that's not total
> > nonsense.
> > 
> > FIXME killing the checks entirely is probably a better idea
> 
> At least killing the totally outdated SAREA comment would be good ;-) But
> yeah I really don't see much point in this, especially since we'll
> happily frob plane C on ilk/snb despite that we're only supporting it on
> ivb+ really.
> 
> Looking through git history with git blame it seems like this went defunct
> somewhere in the large modesetting rewrite. Or even earlier ... in any
> case very confusing history and ripe for the bin.

Forgotten to add: The actually still working "can we update SAREA?" test
is in intel_crtc_update_sarea. That should be mentioned in the commit
message.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch