* [PATCH] drm/i915: Match debugfs interface name to new RPS naming
@ 2014-03-30 8:21 deepak.s
2014-03-30 19:19 ` Ben Widawsky
2014-03-31 6:00 ` [PATCH v2] " deepak.s
0 siblings, 2 replies; 5+ messages in thread
From: deepak.s @ 2014-03-30 8:21 UTC (permalink / raw)
To: intel-gfx; +Cc: Deepak S, benjamin.widawsky
From: Deepak S <deepak.s@intel.com>
Let's change the i915_cur_delayinfo to i915_cur_freqinfo to be in sync
with new RPS naming convention.
Signed-off-by: Deepak S <deepak.s@intel.com>
---
drivers/gpu/drm/i915/i915_debugfs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
index 049dcb5..3cfc35c 100644
--- a/drivers/gpu/drm/i915/i915_debugfs.c
+++ b/drivers/gpu/drm/i915/i915_debugfs.c
@@ -966,7 +966,7 @@ static int i915_rstdby_delays(struct seq_file *m, void *unused)
return 0;
}
-static int i915_cur_delayinfo(struct seq_file *m, void *unused)
+static int i915_cur_freqinfo(struct seq_file *m, void *unused)
{
struct drm_info_node *node = (struct drm_info_node *) m->private;
struct drm_device *dev = node->minor->dev;
@@ -3772,7 +3772,7 @@ static const struct drm_info_list i915_debugfs_list[] = {
{"i915_gem_hws_bsd", i915_hws_info, 0, (void *)VCS},
{"i915_gem_hws_vebox", i915_hws_info, 0, (void *)VECS},
{"i915_rstdby_delays", i915_rstdby_delays, 0},
- {"i915_cur_delayinfo", i915_cur_delayinfo, 0},
+ {"i915_cur_freqinfo", i915_cur_freqinfo, 0},
{"i915_delayfreq_table", i915_delayfreq_table, 0},
{"i915_inttoext_table", i915_inttoext_table, 0},
{"i915_drpc_info", i915_drpc_info, 0},
--
1.8.5.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915: Match debugfs interface name to new RPS naming
2014-03-30 8:21 [PATCH] drm/i915: Match debugfs interface name to new RPS naming deepak.s
@ 2014-03-30 19:19 ` Ben Widawsky
2014-03-31 6:00 ` [PATCH v2] " deepak.s
1 sibling, 0 replies; 5+ messages in thread
From: Ben Widawsky @ 2014-03-30 19:19 UTC (permalink / raw)
To: deepak.s; +Cc: Deepak S, intel-gfx
On Sun, Mar 30, 2014 at 01:51:30PM +0530, deepak.s@linux.intel.com wrote:
> From: Deepak S <deepak.s@intel.com>
>
> Let's change the i915_cur_delayinfo to i915_cur_freqinfo to be in sync
> with new RPS naming convention.
>
> Signed-off-by: Deepak S <deepak.s@intel.com>
If we're doing a rename, we might as well do a rename. The function does
plenty more than "cur"
my vote:
i915_frequency_info
> ---
> drivers/gpu/drm/i915/i915_debugfs.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> index 049dcb5..3cfc35c 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -966,7 +966,7 @@ static int i915_rstdby_delays(struct seq_file *m, void *unused)
> return 0;
> }
>
> -static int i915_cur_delayinfo(struct seq_file *m, void *unused)
> +static int i915_cur_freqinfo(struct seq_file *m, void *unused)
> {
> struct drm_info_node *node = (struct drm_info_node *) m->private;
> struct drm_device *dev = node->minor->dev;
> @@ -3772,7 +3772,7 @@ static const struct drm_info_list i915_debugfs_list[] = {
> {"i915_gem_hws_bsd", i915_hws_info, 0, (void *)VCS},
> {"i915_gem_hws_vebox", i915_hws_info, 0, (void *)VECS},
> {"i915_rstdby_delays", i915_rstdby_delays, 0},
> - {"i915_cur_delayinfo", i915_cur_delayinfo, 0},
> + {"i915_cur_freqinfo", i915_cur_freqinfo, 0},
> {"i915_delayfreq_table", i915_delayfreq_table, 0},
> {"i915_inttoext_table", i915_inttoext_table, 0},
> {"i915_drpc_info", i915_drpc_info, 0},
> --
> 1.8.5.2
>
--
Ben Widawsky, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] drm/i915: Match debugfs interface name to new RPS naming
2014-03-30 8:21 [PATCH] drm/i915: Match debugfs interface name to new RPS naming deepak.s
2014-03-30 19:19 ` Ben Widawsky
@ 2014-03-31 6:00 ` deepak.s
2014-03-31 8:43 ` Daniel Vetter
2014-03-31 18:08 ` Ben Widawsky
1 sibling, 2 replies; 5+ messages in thread
From: deepak.s @ 2014-03-31 6:00 UTC (permalink / raw)
To: intel-gfx; +Cc: benjamin.widawsky
From: Deepak S <deepak.s@linux.intel.com>
Let's change the i915_cur_delayinfo to i915_frequency_info to be in sync
with new RPS naming convention.
v2: Add "i915_frequency_info" as debugfs interface name (Ben)
Signed-off-by: Deepak S <deepak.s@linux.intel.com>
---
drivers/gpu/drm/i915/i915_debugfs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
index 1a35215..e5d9a902 100644
--- a/drivers/gpu/drm/i915/i915_debugfs.c
+++ b/drivers/gpu/drm/i915/i915_debugfs.c
@@ -966,7 +966,7 @@ static int i915_rstdby_delays(struct seq_file *m, void *unused)
return 0;
}
-static int i915_cur_delayinfo(struct seq_file *m, void *unused)
+static int i915_frequency_info(struct seq_file *m, void *unused)
{
struct drm_info_node *node = (struct drm_info_node *) m->private;
struct drm_device *dev = node->minor->dev;
@@ -3786,7 +3786,7 @@ static const struct drm_info_list i915_debugfs_list[] = {
{"i915_gem_hws_bsd", i915_hws_info, 0, (void *)VCS},
{"i915_gem_hws_vebox", i915_hws_info, 0, (void *)VECS},
{"i915_rstdby_delays", i915_rstdby_delays, 0},
- {"i915_cur_delayinfo", i915_cur_delayinfo, 0},
+ {"i915_frequency_info", i915_frequency_info, 0},
{"i915_delayfreq_table", i915_delayfreq_table, 0},
{"i915_inttoext_table", i915_inttoext_table, 0},
{"i915_drpc_info", i915_drpc_info, 0},
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] drm/i915: Match debugfs interface name to new RPS naming
2014-03-31 6:00 ` [PATCH v2] " deepak.s
@ 2014-03-31 8:43 ` Daniel Vetter
2014-03-31 18:08 ` Ben Widawsky
1 sibling, 0 replies; 5+ messages in thread
From: Daniel Vetter @ 2014-03-31 8:43 UTC (permalink / raw)
To: deepak.s; +Cc: intel-gfx, benjamin.widawsky
On Mon, Mar 31, 2014 at 11:30:02AM +0530, deepak.s@linux.intel.com wrote:
> From: Deepak S <deepak.s@linux.intel.com>
>
> Let's change the i915_cur_delayinfo to i915_frequency_info to be in sync
> with new RPS naming convention.
>
> v2: Add "i915_frequency_info" as debugfs interface name (Ben)
>
> Signed-off-by: Deepak S <deepak.s@linux.intel.com>
Yeah, I always need to do a grep .* CAGF to find this file ;-) Queued for
-next, thanks for the patch.
-Daniel
> ---
> drivers/gpu/drm/i915/i915_debugfs.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> index 1a35215..e5d9a902 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -966,7 +966,7 @@ static int i915_rstdby_delays(struct seq_file *m, void *unused)
> return 0;
> }
>
> -static int i915_cur_delayinfo(struct seq_file *m, void *unused)
> +static int i915_frequency_info(struct seq_file *m, void *unused)
> {
> struct drm_info_node *node = (struct drm_info_node *) m->private;
> struct drm_device *dev = node->minor->dev;
> @@ -3786,7 +3786,7 @@ static const struct drm_info_list i915_debugfs_list[] = {
> {"i915_gem_hws_bsd", i915_hws_info, 0, (void *)VCS},
> {"i915_gem_hws_vebox", i915_hws_info, 0, (void *)VECS},
> {"i915_rstdby_delays", i915_rstdby_delays, 0},
> - {"i915_cur_delayinfo", i915_cur_delayinfo, 0},
> + {"i915_frequency_info", i915_frequency_info, 0},
> {"i915_delayfreq_table", i915_delayfreq_table, 0},
> {"i915_inttoext_table", i915_inttoext_table, 0},
> {"i915_drpc_info", i915_drpc_info, 0},
> --
> 1.9.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] drm/i915: Match debugfs interface name to new RPS naming
2014-03-31 6:00 ` [PATCH v2] " deepak.s
2014-03-31 8:43 ` Daniel Vetter
@ 2014-03-31 18:08 ` Ben Widawsky
1 sibling, 0 replies; 5+ messages in thread
From: Ben Widawsky @ 2014-03-31 18:08 UTC (permalink / raw)
To: deepak.s; +Cc: intel-gfx
On Mon, Mar 31, 2014 at 11:30:02AM +0530, deepak.s@linux.intel.com wrote:
> From: Deepak S <deepak.s@linux.intel.com>
>
> Let's change the i915_cur_delayinfo to i915_frequency_info to be in sync
> with new RPS naming convention.
>
> v2: Add "i915_frequency_info" as debugfs interface name (Ben)
>
> Signed-off-by: Deepak S <deepak.s@linux.intel.com>
Provided that nobody cares about debugfs as an ABI -
Reviewed-by: Ben Widawsky <ben@bwidawsk.net>
> ---
> drivers/gpu/drm/i915/i915_debugfs.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> index 1a35215..e5d9a902 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -966,7 +966,7 @@ static int i915_rstdby_delays(struct seq_file *m, void *unused)
> return 0;
> }
>
> -static int i915_cur_delayinfo(struct seq_file *m, void *unused)
> +static int i915_frequency_info(struct seq_file *m, void *unused)
> {
> struct drm_info_node *node = (struct drm_info_node *) m->private;
> struct drm_device *dev = node->minor->dev;
> @@ -3786,7 +3786,7 @@ static const struct drm_info_list i915_debugfs_list[] = {
> {"i915_gem_hws_bsd", i915_hws_info, 0, (void *)VCS},
> {"i915_gem_hws_vebox", i915_hws_info, 0, (void *)VECS},
> {"i915_rstdby_delays", i915_rstdby_delays, 0},
> - {"i915_cur_delayinfo", i915_cur_delayinfo, 0},
> + {"i915_frequency_info", i915_frequency_info, 0},
> {"i915_delayfreq_table", i915_delayfreq_table, 0},
> {"i915_inttoext_table", i915_inttoext_table, 0},
> {"i915_drpc_info", i915_drpc_info, 0},
> --
> 1.9.1
>
--
Ben Widawsky, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-03-31 18:09 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-30 8:21 [PATCH] drm/i915: Match debugfs interface name to new RPS naming deepak.s
2014-03-30 19:19 ` Ben Widawsky
2014-03-31 6:00 ` [PATCH v2] " deepak.s
2014-03-31 8:43 ` Daniel Vetter
2014-03-31 18:08 ` Ben Widawsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox