From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/i915: vlv: reserve the GT power context
 only once during driver init
Date: Tue, 1 Apr 2014 22:31:41 +0200
Message-ID: <20140401203130.GA7225@phenom.ffwll.local>
References: <1396267844-9235-1-git-send-email-imre.deak@intel.com>
 <20140401171122.GJ21652@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-we0-f181.google.com (mail-we0-f181.google.com
 [74.125.82.181])
 by gabe.freedesktop.org (Postfix) with ESMTP id 9E3046E84F
 for <intel-gfx@lists.freedesktop.org>; Tue,  1 Apr 2014 13:31:50 -0700 (PDT)
Received: by mail-we0-f181.google.com with SMTP id q58so6600809wes.26
 for <intel-gfx@lists.freedesktop.org>; Tue, 01 Apr 2014 13:31:49 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20140401171122.GJ21652@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Tue, Apr 01, 2014 at 08:11:22PM +0300, Ville Syrj=E4l=E4 wrote:
> On Mon, Mar 31, 2014 at 03:10:44PM +0300, Imre Deak wrote:
> > Atm we reserve/allocate and free the power context during GT power
> > enable/disable time. There is no need to do this, we can reserve/alloca=
te
> > the buffer once during driver loading and free it during driver cleanup.
> > The re-reservation can also fail in case the driver previously manages =
to
> > allocate something on the given fixed address.
> > =

> > The buffer isn't exepected to move even if allocated by the BIOS, for
> > safety add an assert to check this assumption.
> > =

> > This also fixed a bug for Ville, where re-reserving the context failed
> > during a GPU reset (I assume because something else got allocated on its
> > fixed address).
> =

> I'm assuming it was the already existing pctx allocation that caused the
> warning. We just call intel_enable_gt_powersave() again during GPU reset
> w/o having called intel_disable_gt_powersave() anywhere. So no danger of
> clobbering the pctx AFAICS, but getting a WARN on every GPU reset is
> rather annoying.
> =

> > =

> > Tested-by: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
> > Signed-off-by: Imre Deak <imre.deak@intel.com>
> =

> The patch looks good to me.
> =

> Reviewed-by: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>

Queued for -next, thanks for the patch.
-Daniel
-- =

Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch