From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Widawsky Subject: Re: [PATCH 2/3] [v2] drm/i915/bdw: Render ring PDP is restored with context Date: Tue, 1 Apr 2014 20:35:58 -0700 Message-ID: <20140402033558.GA7144@bwidawsk.net> References: <1396399052-20612-2-git-send-email-benjamin.widawsky@intel.com> <1396399386-3825-1-git-send-email-benjamin.widawsky@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail.bwidawsk.net (bwidawsk.net [166.78.191.112]) by gabe.freedesktop.org (Postfix) with ESMTP id 32F766E605 for ; Tue, 1 Apr 2014 20:36:10 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1396399386-3825-1-git-send-email-benjamin.widawsky@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ben Widawsky Cc: Intel GFX List-Id: intel-gfx@lists.freedesktop.org On Tue, Apr 01, 2014 at 05:43:06PM -0700, Ben Widawsky wrote: > So let's not do it every time we switch. > > v2: v1 skipped the switch for all gens. We still need it pre-gen8. > > Signed-off-by: Ben Widawsky Please ignore this patch. I actually need to rework some stuff. 1 and 3 are still good though. > --- > drivers/gpu/drm/i915/i915_gem_context.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/i915_gem_context.c b/drivers/gpu/drm/i915/i915_gem_context.c > index 0e8fd1e..3b5b8ab 100644 > --- a/drivers/gpu/drm/i915/i915_gem_context.c > +++ b/drivers/gpu/drm/i915/i915_gem_context.c > @@ -710,7 +710,8 @@ static int do_switch(struct intel_ring_buffer *ring, > if (ret) > goto unpin_out; > > - if (USES_FULL_PPGTT(ring->dev)) { > + if (USES_FULL_PPGTT(ring->dev) && > + (!IS_GEN8(ring->dev) || !to->is_initialized)) { > ret = ppgtt->switch_mm(ppgtt, ring, false); > /* The hardware context switch is emitted, but we haven't > * actually changed the state - so it's probably safe to bail > -- > 1.9.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Ben Widawsky, Intel Open Source Technology Center