From: Ben Widawsky <ben@bwidawsk.net>
To: ville.syrjala@linux.intel.com
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 3/3] drm/i915: Implement WaProgramMiArbOnOffAroundMiSetContext:bdw
Date: Tue, 1 Apr 2014 21:55:04 -0700 [thread overview]
Message-ID: <20140402045504.GA13824@bwidawsk.net> (raw)
In-Reply-To: <1396279038-28914-4-git-send-email-ville.syrjala@linux.intel.com>
On Mon, Mar 31, 2014 at 06:17:18PM +0300, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> BSpec seems to tell us we need the MI_ARB_ON_OFF w/a around
> MI_SET_CONTEXT on gen8.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Ben Widawsky <ben@bwidawsk.net>
> ---
> drivers/gpu/drm/i915/i915_gem_context.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gem_context.c b/drivers/gpu/drm/i915/i915_gem_context.c
> index 746fb23..28a2b15 100644
> --- a/drivers/gpu/drm/i915/i915_gem_context.c
> +++ b/drivers/gpu/drm/i915/i915_gem_context.c
> @@ -606,8 +606,8 @@ mi_set_context(struct intel_ring_buffer *ring,
> if (ret)
> return ret;
>
> - /* WaProgramMiArbOnOffAroundMiSetContext:ivb,vlv,hsw */
> - if (IS_GEN7(ring->dev))
> + /* WaProgramMiArbOnOffAroundMiSetContext:ivb,vlv,hsw,bdw */
> + if (INTEL_INFO(ring->dev)->gen >= 7)
> intel_ring_emit(ring, MI_ARB_ON_OFF | MI_ARB_DISABLE);
> else
> intel_ring_emit(ring, MI_NOOP);
> @@ -625,7 +625,7 @@ mi_set_context(struct intel_ring_buffer *ring,
> */
> intel_ring_emit(ring, MI_NOOP);
>
> - if (IS_GEN7(ring->dev))
> + if (INTEL_INFO(ring->dev)->gen >= 7)
> intel_ring_emit(ring, MI_ARB_ON_OFF | MI_ARB_ENABLE);
> else
> intel_ring_emit(ring, MI_NOOP);
> --
> 1.8.3.2
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ben Widawsky, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2014-04-02 4:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-31 15:17 [PATCH 0/3] drm/i915: Gen8 workarounds and debugfs fix ville.syrjala
2014-03-31 15:17 ` [PATCH 1/3] drm/i915: Fix debugfs PDP register dump ville.syrjala
2014-04-02 17:28 ` Ben Widawsky
2014-04-03 9:26 ` Daniel Vetter
2014-03-31 15:17 ` [PATCH 2/3] drm/i915: Implement sema idle msg disable for all rings ville.syrjala
2014-03-31 17:23 ` Daniel Vetter
2014-03-31 18:01 ` Ville Syrjälä
2014-03-31 15:17 ` [PATCH 3/3] drm/i915: Implement WaProgramMiArbOnOffAroundMiSetContext:bdw ville.syrjala
2014-04-02 4:55 ` Ben Widawsky [this message]
2014-04-02 7:11 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140402045504.GA13824@bwidawsk.net \
--to=ben@bwidawsk.net \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox