From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/i915: Fix the computation of required
 fb size for pipe
Date: Wed, 2 Apr 2014 09:10:44 +0200
Message-ID: <20140402071044.GI7225@phenom.ffwll.local>
References: <1395328281-15867-1-git-send-email-chris@chris-wilson.co.uk>
 <20140402065818.GM7314@nuc-i3427.alporthouse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-wi0-f178.google.com (mail-wi0-f178.google.com
 [209.85.212.178])
 by gabe.freedesktop.org (Postfix) with ESMTP id 1F3DB6E941
 for <intel-gfx@lists.freedesktop.org>; Wed,  2 Apr 2014 00:10:48 -0700 (PDT)
Received: by mail-wi0-f178.google.com with SMTP id bs8so6446913wib.17
 for <intel-gfx@lists.freedesktop.org>; Wed, 02 Apr 2014 00:10:46 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20140402065818.GM7314@nuc-i3427.alporthouse.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org, Jesse Barnes <jbarnes@virtuousgeek.org>
List-Id: intel-gfx@lists.freedesktop.org

On Wed, Apr 02, 2014 at 07:58:18AM +0100, Chris Wilson wrote:
> On Thu, Mar 20, 2014 at 03:11:21PM +0000, Chris Wilson wrote:
> > The computation of required framebuffer size in
> > 
> > commit d978ef14456a38034f6c0e94a794129501f89200
> > Author: Jesse Barnes <jbarnes@virtuousgeek.org>
> > Date:   Fri Mar 7 08:57:51 2014 -0800
> > 
> >     drm/i915: Wrap the preallocated BIOS framebuffer and preserve for KMS fbcon v12
> > 
> > is too optimistic, and would rely on the invariant fb being
> > reconstructed to exactly fit each pipe (and probably ignore hardware
> > limits). Instead, we want to compute the upper bound on what the display
> > engine will access and ensure that is within the inherited framebuffer.
> > 
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
> 
> Ping. The code is just waiting to explode.

I kinda hoped it would magically get reviewed by Jesse. Thanks for the
ping, patch is picked up for -fixes.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch