From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [PATCH] drm/i915: Fix the computation of required
 fb size for pipe
Date: Wed, 2 Apr 2014 08:03:50 -0700
Message-ID: <20140402080350.28e42519@jbarnes-desktop>
References: <1395328281-15867-1-git-send-email-chris@chris-wilson.co.uk>
 <20140402065818.GM7314@nuc-i3427.alporthouse.com>
 <20140402071044.GI7225@phenom.ffwll.local>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from gproxy3-pub.mail.unifiedlayer.com
 (gproxy3-pub.mail.unifiedlayer.com [69.89.30.42])
 by gabe.freedesktop.org (Postfix) with SMTP id 10A226EB6C
 for <intel-gfx@lists.freedesktop.org>; Wed,  2 Apr 2014 08:02:44 -0700 (PDT)
In-Reply-To: <20140402071044.GI7225@phenom.ffwll.local>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Wed, 2 Apr 2014 09:10:44 +0200
Daniel Vetter <daniel@ffwll.ch> wrote:

> On Wed, Apr 02, 2014 at 07:58:18AM +0100, Chris Wilson wrote:
> > On Thu, Mar 20, 2014 at 03:11:21PM +0000, Chris Wilson wrote:
> > > The computation of required framebuffer size in
> > > 
> > > commit d978ef14456a38034f6c0e94a794129501f89200
> > > Author: Jesse Barnes <jbarnes@virtuousgeek.org>
> > > Date:   Fri Mar 7 08:57:51 2014 -0800
> > > 
> > >     drm/i915: Wrap the preallocated BIOS framebuffer and preserve for KMS fbcon v12
> > > 
> > > is too optimistic, and would rely on the invariant fb being
> > > reconstructed to exactly fit each pipe (and probably ignore hardware
> > > limits). Instead, we want to compute the upper bound on what the display
> > > engine will access and ensure that is within the inherited framebuffer.
> > > 
> > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > > Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
> > 
> > Ping. The code is just waiting to explode.
> 
> I kinda hoped it would magically get reviewed by Jesse. Thanks for the
> ping, patch is picked up for -fixes.

Yeah sorry my brain exploded when looking at this for the nth time so I
kept putting it off.

Looks fine now though, so belated R-b from me.

-- 
Jesse Barnes, Intel Open Source Technology Center