From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH i-g-t 5/7] kms_cursor_crc: Add reference software rendering Date: Wed, 2 Apr 2014 14:21:59 +0300 Message-ID: <20140402112159.GO21652@intel.com> References: <1396436790-14313-1-git-send-email-antti.koskipaa@linux.intel.com> <1396436790-14313-6-git-send-email-antti.koskipaa@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 5A7E16EA72 for ; Wed, 2 Apr 2014 04:22:47 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1396436790-14313-6-git-send-email-antti.koskipaa@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Antti Koskipaa Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, Apr 02, 2014 at 02:06:28PM +0300, Antti Koskipaa wrote: > @@ -184,9 +192,6 @@ static void test_crc_offscreen(test_data_t *test_data) > do_test(test_data, left - (cursor_w+512), right + (cursor_w+512), top = , bottom ); > do_test(test_data, left , right , top -= (cursor_h+512), bottom + (cursor_h+512)); > do_test(test_data, left - (cursor_w+512), right + (cursor_w+512), top -= (cursor_h+512), bottom + (cursor_h+512)); > - > - /* go nuts */ > - do_test(test_data, INT_MIN, INT_MAX, INT_MIN, INT_MAX); Why are you dropping the go nuts test? We had an actual bug in the driver that this managed to hit. We should keep this test to avoid regressions. -- = Ville Syrj=E4l=E4 Intel OTC