From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH i-g-t 5/7] kms_cursor_crc: Add reference
 software rendering
Date: Wed, 2 Apr 2014 14:38:11 +0300
Message-ID: <20140402113811.GQ21652@intel.com>
References: <1396436790-14313-1-git-send-email-antti.koskipaa@linux.intel.com>
 <1396436790-14313-6-git-send-email-antti.koskipaa@linux.intel.com>
 <20140402112159.GO21652@intel.com>
 <533BF42C.7030106@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by gabe.freedesktop.org (Postfix) with ESMTP id ED6F06EA8A
 for <intel-gfx@lists.freedesktop.org>; Wed,  2 Apr 2014 04:38:14 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <533BF42C.7030106@linux.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Antti =?iso-8859-1?Q?Koskip=E4=E4?= <antti.koskipaa@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Wed, Apr 02, 2014 at 02:27:40PM +0300, Antti Koskip=E4=E4 wrote:
> On 04/02/2014 02:21 PM, Ville Syrj=E4l=E4 wrote:
> > On Wed, Apr 02, 2014 at 02:06:28PM +0300, Antti Koskipaa wrote:
> > <snip>
> >> @@ -184,9 +192,6 @@ static void test_crc_offscreen(test_data_t *test_d=
ata)
> >>  	do_test(test_data, left - (cursor_w+512), right + (cursor_w+512), to=
p                 , bottom                 );
> >>  	do_test(test_data, left                 , right                 , to=
p - (cursor_h+512), bottom + (cursor_h+512));
> >>  	do_test(test_data, left - (cursor_w+512), right + (cursor_w+512), to=
p - (cursor_h+512), bottom + (cursor_h+512));
> >> -
> >> -	/* go nuts */
> >> -	do_test(test_data, INT_MIN, INT_MAX, INT_MIN, INT_MAX);
> > =

> > Why are you dropping the go nuts test? We had an actual bug in the
> > driver that this managed to hit. We should keep this test to avoid
> > regressions.
> =

> Link please. Cairo went nuts with that one, but if there is a case for
> the test, I'll work around Cairo to keep it.

commit 92e76c8c7e436a07af3e0b594480ff8689add078
Author: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
Date:   Mon Oct 21 19:01:58 2013 +0300

    drm/i915: Clamp cursor coordinates to int16_t range

is the commit that fixed the bug.

-- =

Ville Syrj=E4l=E4
Intel OTC