From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [PATCH 3/6] drm/i915: Preserve ring buffers objects
 across resume
Date: Wed, 2 Apr 2014 15:10:13 -0700
Message-ID: <20140402151013.4e37c8c8@jbarnes-desktop>
References: <1396452971-25654-1-git-send-email-chris@chris-wilson.co.uk>
 <1396452971-25654-3-git-send-email-chris@chris-wilson.co.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from gproxy4-pub.mail.unifiedlayer.com
 (gproxy4-pub.mail.unifiedlayer.com [69.89.23.142])
 by gabe.freedesktop.org (Postfix) with SMTP id EB3416EC3C
 for <intel-gfx@lists.freedesktop.org>; Wed,  2 Apr 2014 15:09:01 -0700 (PDT)
In-Reply-To: <1396452971-25654-3-git-send-email-chris@chris-wilson.co.uk>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Wed,  2 Apr 2014 16:36:08 +0100
Chris Wilson <chris@chris-wilson.co.uk> wrote:

> +static void
> +i915_gem_stop_ringbuffers(struct drm_device *dev)
> +{
> +	struct drm_i915_private *dev_priv = dev->dev_private;
> +	struct intel_ring_buffer *ring;
> +	int i;
> +
> +	for_each_ring(ring, dev_priv, i)
> +		intel_cleanup_ring_buffer(ring);
> +}
> +

You've improved the init/alloc ringbuffer naming, but this one
confuses me.  stop_ringbuffers to me says we're just idling them, but
cleanup_ring_buffer actually does the unmap and free right?

If so, it looks like this will still tear things down on suspend?

Maybe it's all the refactoring making me miss it. :)

-- 
Jesse Barnes, Intel Open Source Technology Center