From mboxrd@z Thu Jan 1 00:00:00 1970 From: Damien Lespiau Subject: Re: [PATCH 5/7] drm/i915: Provide a bit more info when pipestat bits are wrong Date: Wed, 2 Apr 2014 22:35:19 +0100 Message-ID: <20140402213519.GA11052@strange.amr.corp.intel.com> References: <1396279290-29435-1-git-send-email-ville.syrjala@linux.intel.com> <1396279290-29435-6-git-send-email-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id A67976EC23 for ; Wed, 2 Apr 2014 14:35:21 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1396279290-29435-6-git-send-email-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: ville.syrjala@linux.intel.com Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Mon, Mar 31, 2014 at 06:21:28PM +0300, ville.syrjala@linux.intel.com wro= te: > From: Ville Syrj=E4l=E4 > = > Print the enable_mask and status_mask from > __i915_{enable,disable}_pipestat() when the called has messed them up > somehow. > = > Signed-off-by: Ville Syrj=E4l=E4 > --- > drivers/gpu/drm/i915/i915_irq.c | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) > = > diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_= irq.c > index 6d26719..407742f 100644 > --- a/drivers/gpu/drm/i915/i915_irq.c > +++ b/drivers/gpu/drm/i915/i915_irq.c > @@ -503,8 +503,10 @@ __i915_enable_pipestat(struct drm_i915_private *dev_= priv, enum pipe pipe, > = > assert_spin_locked(&dev_priv->irq_lock); > = > - if (WARN_ON_ONCE(enable_mask & ~PIPESTAT_INT_ENABLE_MASK || > - status_mask & ~PIPESTAT_INT_STATUS_MASK)) > + if (WARN_ONCE(enable_mask & ~PIPESTAT_INT_ENABLE_MASK || > + status_mask & ~PIPESTAT_INT_STATUS_MASK, > + "pipe %c: enable_mask=3D0x%x, status_mask=3D0x%x\n", > + pipe, enable_mask, status_mask)) pipe_name(pipe)? > return; > = > if ((pipestat & enable_mask) =3D=3D enable_mask) > @@ -527,8 +529,10 @@ __i915_disable_pipestat(struct drm_i915_private *dev= _priv, enum pipe pipe, > = > assert_spin_locked(&dev_priv->irq_lock); > = > - if (WARN_ON_ONCE(enable_mask & ~PIPESTAT_INT_ENABLE_MASK || > - status_mask & ~PIPESTAT_INT_STATUS_MASK)) > + if (WARN_ONCE(enable_mask & ~PIPESTAT_INT_ENABLE_MASK || > + status_mask & ~PIPESTAT_INT_STATUS_MASK, > + "pipe %c: enable_mask=3D0x%x, status_mask=3D0x%x\n", > + pipe, enable_mask, status_mask)) > return; Ditto. > = > if ((pipestat & enable_mask) =3D=3D 0) > -- = > 1.8.3.2 > = > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx