From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 3/4] drm/i915: enable HDMI mode on VLV when an HDMI sink is detected
Date: Thu, 3 Apr 2014 13:30:26 +0300 [thread overview]
Message-ID: <20140403103026.GU21652@intel.com> (raw)
In-Reply-To: <1396458534-23108-3-git-send-email-jbarnes@virtuousgeek.org>
On Wed, Apr 02, 2014 at 10:08:53AM -0700, Jesse Barnes wrote:
> Allows sending of the null packets for conformance.
Just set it for all platforms? I'm not aware of any downside of setting
it always.
Anyways seems sane enough so even for just VLV:
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> ---
> drivers/gpu/drm/i915/intel_hdmi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c
> index 3b804fc..fb9839b 100644
> --- a/drivers/gpu/drm/i915/intel_hdmi.c
> +++ b/drivers/gpu/drm/i915/intel_hdmi.c
> @@ -650,8 +650,8 @@ static void intel_hdmi_mode_set(struct intel_encoder *encoder)
> else
> hdmi_val |= SDVO_COLOR_FORMAT_8bpc;
>
> - /* Required on CPT */
> - if (intel_hdmi->has_hdmi_sink && HAS_PCH_CPT(dev))
> + if (intel_hdmi->has_hdmi_sink &&
> + (HAS_PCH_CPT(dev) || IS_VALLEYVIEW(dev)))
> hdmi_val |= HDMI_MODE_SELECT_HDMI;
>
> if (intel_hdmi->has_audio) {
> --
> 1.7.9.5
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel OTC
next prev parent reply other threads:[~2014-04-03 10:30 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-02 17:08 [PATCH 1/4] drm/i915/vlv: write the port field in the per-pipe DIP control reg Jesse Barnes
2014-04-02 17:08 ` [PATCH 2/4] drm/i915/vlv: disable AVI infoframe emission when writing infoframes Jesse Barnes
2014-04-03 10:33 ` Ville Syrjälä
2014-04-02 17:08 ` [PATCH 3/4] drm/i915: enable HDMI mode on VLV when an HDMI sink is detected Jesse Barnes
2014-04-03 10:30 ` Ville Syrjälä [this message]
2014-04-02 17:08 ` [PATCH 4/4] drm/i915: move infoframe setting to after port enable Jesse Barnes
2014-04-03 7:41 ` Jani Nikula
2014-04-03 10:31 ` Ville Syrjälä
2014-04-03 15:19 ` Daniel Vetter
2014-04-03 16:49 ` Jesse Barnes
2014-04-03 20:55 ` Daniel Vetter
2014-04-03 21:00 ` Jesse Barnes
2014-04-04 21:11 ` Paulo Zanoni
2014-04-05 15:18 ` Daniel Vetter
2014-04-04 21:38 ` [PATCH] drm/i915: move infoframe setting to after pll enable v2 Jesse Barnes
2014-04-04 21:59 ` Paulo Zanoni
2014-04-04 22:12 ` Jesse Barnes
2014-04-05 15:21 ` Daniel Vetter
2014-04-05 18:51 ` Jesse Barnes
2014-04-05 18:51 ` [PATCH] drm/i915: move infoframe setting to after pll enable v3 Jesse Barnes
2014-04-07 12:54 ` Paulo Zanoni
2014-04-09 12:48 ` Daniel Vetter
2014-04-02 17:10 ` [PATCH 1/4] drm/i915/vlv: write the port field in the per-pipe DIP control reg Jesse Barnes
2014-04-04 19:25 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140403103026.GU21652@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox