From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 3/4] drm/i915: enable HDMI mode on VLV when an HDMI sink is detected Date: Thu, 3 Apr 2014 13:30:26 +0300 Message-ID: <20140403103026.GU21652@intel.com> References: <1396458534-23108-1-git-send-email-jbarnes@virtuousgeek.org> <1396458534-23108-3-git-send-email-jbarnes@virtuousgeek.org> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 3B8B26E8D7 for ; Thu, 3 Apr 2014 03:30:30 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1396458534-23108-3-git-send-email-jbarnes@virtuousgeek.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jesse Barnes Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, Apr 02, 2014 at 10:08:53AM -0700, Jesse Barnes wrote: > Allows sending of the null packets for conformance. Just set it for all platforms? I'm not aware of any downside of setting it always. Anyways seems sane enough so even for just VLV: Reviewed-by: Ville Syrj=E4l=E4 > = > Signed-off-by: Jesse Barnes > --- > drivers/gpu/drm/i915/intel_hdmi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > = > diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/int= el_hdmi.c > index 3b804fc..fb9839b 100644 > --- a/drivers/gpu/drm/i915/intel_hdmi.c > +++ b/drivers/gpu/drm/i915/intel_hdmi.c > @@ -650,8 +650,8 @@ static void intel_hdmi_mode_set(struct intel_encoder = *encoder) > else > hdmi_val |=3D SDVO_COLOR_FORMAT_8bpc; > = > - /* Required on CPT */ > - if (intel_hdmi->has_hdmi_sink && HAS_PCH_CPT(dev)) > + if (intel_hdmi->has_hdmi_sink && > + (HAS_PCH_CPT(dev) || IS_VALLEYVIEW(dev))) > hdmi_val |=3D HDMI_MODE_SELECT_HDMI; > = > if (intel_hdmi->has_audio) { > -- = > 1.7.9.5 > = > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- = Ville Syrj=E4l=E4 Intel OTC