From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v2] drm/i915: Make contexts non-snooped on non-LLC platforms Date: Fri, 4 Apr 2014 18:00:15 +0200 Message-ID: <20140404160015.GU7225@phenom.ffwll.local> References: <1396278589-27882-1-git-send-email-ville.syrjala@linux.intel.com> <1396618570-11475-1-git-send-email-ville.syrjala@linux.intel.com> <20140404134100.GC21064@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-we0-f180.google.com (mail-we0-f180.google.com [74.125.82.180]) by gabe.freedesktop.org (Postfix) with ESMTP id F36466E04D for ; Fri, 4 Apr 2014 09:00:18 -0700 (PDT) Received: by mail-we0-f180.google.com with SMTP id p61so3592328wes.25 for ; Fri, 04 Apr 2014 09:00:18 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20140404134100.GC21064@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , ville.syrjala@linux.intel.com, intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, Apr 04, 2014 at 02:41:00PM +0100, Chris Wilson wrote: > On Fri, Apr 04, 2014 at 04:36:10PM +0300, ville.syrjala@linux.intel.com w= rote: > > From: Ville Syrj=E4l=E4 > > = > > We don't do CPU access to GPU contexts so making the GPU access snoop > > the CPU caches seems silly, and potentially expensive. > > = > > v2: Use !IS_VALLEYVIEW instead of HAS_LLC as this is really > > about what the PTEs can represent. > > Add a comment clarifying the situation. > > = > > Signed-off-by: Ville Syrj=E4l=E4 > Reviewed-by: Chris Wilson Queued for -next, thanks for the patch. -Daniel -- = Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch