From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 3/6] drm/i915: warn when a vblank wait times out Date: Mon, 7 Apr 2014 08:20:13 +0200 Message-ID: <20140407062013.GB9262@phenom.ffwll.local> References: <1396653132-908-1-git-send-email-jbarnes@virtuousgeek.org> <1396653132-908-3-git-send-email-jbarnes@virtuousgeek.org> <20140405062922.GE8475@nuc-i3427.alporthouse.com> <20140405152240.GX7225@phenom.ffwll.local> <20140405115238.6c246f89@jbarnes-desktop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f52.google.com (mail-ee0-f52.google.com [74.125.83.52]) by gabe.freedesktop.org (Postfix) with ESMTP id 15F806E4EF for ; Sun, 6 Apr 2014 23:20:16 -0700 (PDT) Received: by mail-ee0-f52.google.com with SMTP id e49so243118eek.11 for ; Sun, 06 Apr 2014 23:20:16 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20140405115238.6c246f89@jbarnes-desktop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jesse Barnes Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Sat, Apr 05, 2014 at 11:52:38AM -0700, Jesse Barnes wrote: > On Sat, 5 Apr 2014 17:22:40 +0200 > Daniel Vetter wrote: > > > On Sat, Apr 05, 2014 at 07:29:22AM +0100, Chris Wilson wrote: > > > On Fri, Apr 04, 2014 at 04:12:09PM -0700, Jesse Barnes wrote: > > > > This always indicates a bug somewhere. > > > > > > We keep turning this off because we hadn't fixed all the bugs - as we > > > try to wait on a dead pipe. Maybe this time we won't be inundated with > > > WARNs... > > > > We're really early in the 3.16 cycle. If Jesse promises to chase down all > > the fallout I'll happily merge this - we really need to get this done > > sometimes. > > It helped me find a missing backport in the Chromium tree for the > vblank code on BYT, so it's already been helpful. > > Let the flood of bug reports begin! Ok ;-) Queued for -next, thanks for the patch. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch