From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 4/6] drm/i915: don't set sink DPMS status on eDP
Date: Mon, 7 Apr 2014 07:58:10 -0700 [thread overview]
Message-ID: <20140407075810.7b2d4faa@jbarnes-desktop> (raw)
In-Reply-To: <87lhvha63l.fsf@intel.com>
On Mon, 07 Apr 2014 11:36:46 +0300
Jani Nikula <jani.nikula@linux.intel.com> wrote:
> On Sat, 05 Apr 2014, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> > This only applies to external sinks.
>
> [citation needed]
>
> eDP 1.3 has SET_POWER_CAPABLE (bit 7) in in DPCD
> EDP_GENERAL_CAPABILITY_REGISTER_1 (register 0x702) which indicates
> whether panel power state can be controlled through DP_SET_POWER. Even
> when the panel is not capable, writing to DP_SET_POWER should have no
> effect on the panel.
>
This one comes from chromium tree. I checked the DP spec but obviously
should have checked eDP too!
I mainly added this to get rid of some noise in the logs about aux
timeouts due to these messages. But on eDP that turned out to be an
unrelated bug, and not due to us sending these messages after all.
So patch withdrawn...
--
Jesse Barnes, Intel Open Source Technology Center
next prev parent reply other threads:[~2014-04-07 14:56 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-04 23:12 [PATCH 1/6] drm/i915: use VBT to determine whether to enumerate the VGA port Jesse Barnes
2014-04-04 23:12 ` [PATCH 2/6] drm/i915: remove unnecessary delays in intel_dp_link_down Jesse Barnes
2014-04-05 6:26 ` Chris Wilson
2014-04-11 21:25 ` [PATCH 1/2] drm/i915: remove unexplained vblank wait in the DP off code Jesse Barnes
2014-04-11 21:25 ` [PATCH 2/2] drm/i915: remove misplaced panel wait in " Jesse Barnes
2014-04-12 7:03 ` [PATCH 1/2] drm/i915: remove unexplained vblank wait in the " Chris Wilson
2014-04-17 12:21 ` Ville Syrjälä
2014-04-22 19:17 ` Daniel Vetter
2014-04-04 23:12 ` [PATCH 3/6] drm/i915: warn when a vblank wait times out Jesse Barnes
2014-04-05 6:29 ` Chris Wilson
2014-04-05 15:22 ` Daniel Vetter
2014-04-05 18:52 ` Jesse Barnes
2014-04-07 6:20 ` Daniel Vetter
2014-04-04 23:12 ` [PATCH 4/6] drm/i915: don't set sink DPMS status on eDP Jesse Barnes
2014-04-07 8:36 ` Jani Nikula
2014-04-07 14:58 ` Jesse Barnes [this message]
2014-04-04 23:12 ` [PATCH 5/6] drm/i915/vlv: move DP enable after plane/pipe enable per latest spec Jesse Barnes
2014-04-04 23:12 ` [PATCH 6/6] drm/i915/vlv: re-order TX lane reset " Jesse Barnes
2014-05-29 21:47 ` [PATCH 1/6] drm/i915: use VBT to determine whether to enumerate the VGA port Ben Widawsky
2014-06-02 8:24 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140407075810.7b2d4faa@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox