From: Damien Lespiau <damien.lespiau@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/i915: Add a module parameter to enable execlists
Date: Mon, 7 Apr 2014 19:26:40 +0100 [thread overview]
Message-ID: <20140407182640.GI6407@strange.amr.corp.intel.com> (raw)
In-Reply-To: <1396879539-25991-3-git-send-email-damien.lespiau@intel.com>
On Mon, Apr 07, 2014 at 03:05:39PM +0100, Damien Lespiau wrote:
> Execlist are relatively new, and so it'd be wise to be able to merge
> that support disabled by default while still allowing a module parameter
> to enable that feature.
>
> Even if we end up enabling execlists by default, it'll be handy to be
> able to switch back to ring submission to debug subtle problems that
> will inevitably arise.
After a quick chat with Daniel on IRC, we actually want that new code to
be enabled by default to get as much testing as possible, while
retaining the module parameter to quickly identify if a bug we're seeing
can be reproduced with the legacy ring submission or not.
> @@ -37,6 +37,7 @@ struct i915_params i915 __read_mostly = {
> .enable_fbc = -1,
> .enable_hangcheck = true,
> .enable_ppgtt = -1,
> + .enable_execlists = 0,
So, this should be -1.
--
Damien
next prev parent reply other threads:[~2014-04-07 18:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-07 14:05 [PATCH 0/2] Module parameter to enable execlists Damien Lespiau
2014-04-07 14:05 ` [PATCH 1/2] drm/i915: Factor out a enable_execlists() function Damien Lespiau
2014-04-07 14:05 ` [PATCH 2/2] drm/i915: Add a module parameter to enable execlists Damien Lespiau
2014-04-07 18:26 ` Damien Lespiau [this message]
2014-04-09 7:58 ` Mateo Lozano, Oscar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140407182640.GI6407@strange.amr.corp.intel.com \
--to=damien.lespiau@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox