From mboxrd@z Thu Jan  1 00:00:00 1970
From: Damien Lespiau <damien.lespiau@intel.com>
Subject: Re: [PATCH 2/2] drm/i915: Add a module parameter to
 enable execlists
Date: Mon, 7 Apr 2014 19:26:40 +0100
Message-ID: <20140407182640.GI6407@strange.amr.corp.intel.com>
References: <1396879539-25991-1-git-send-email-damien.lespiau@intel.com>
 <1396879539-25991-3-git-send-email-damien.lespiau@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by gabe.freedesktop.org (Postfix) with ESMTP id D4FE86E74E
 for <intel-gfx@lists.freedesktop.org>; Mon,  7 Apr 2014 11:26:44 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1396879539-25991-3-git-send-email-damien.lespiau@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Mon, Apr 07, 2014 at 03:05:39PM +0100, Damien Lespiau wrote:
> Execlist are relatively new, and so it'd be wise to be able to merge
> that support disabled by default while still allowing a module parameter
> to enable that feature.
> 
> Even if we end up enabling execlists by default, it'll be handy to be
> able to switch back to ring submission to debug subtle problems that
> will inevitably arise.

After a quick chat with Daniel on IRC, we actually want that new code to
be enabled by default to get as much testing as possible, while
retaining the module parameter to quickly identify if a bug we're seeing
can be reproduced with the legacy ring submission or not.

> @@ -37,6 +37,7 @@ struct i915_params i915 __read_mostly = {
>  	.enable_fbc = -1,
>  	.enable_hangcheck = true,
>  	.enable_ppgtt = -1,
> +	.enable_execlists = 0,

So, this should be -1.

-- 
Damien