From mboxrd@z Thu Jan  1 00:00:00 1970
From: Damien Lespiau <damien.lespiau@intel.com>
Subject: Re: [PATCH 44/49] drm/i915/bdw: Display execlists info
 in debugfs
Date: Mon, 7 Apr 2014 20:19:05 +0100
Message-ID: <20140407191905.GK6407@strange.amr.corp.intel.com>
References: <1395943218-7708-1-git-send-email-oscar.mateo@intel.com>
 <1395943218-7708-45-git-send-email-oscar.mateo@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by gabe.freedesktop.org (Postfix) with ESMTP id 5AAFF6E75F
 for <intel-gfx@lists.freedesktop.org>; Mon,  7 Apr 2014 12:19:26 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1395943218-7708-45-git-send-email-oscar.mateo@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: oscar.mateo@intel.com
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Thu, Mar 27, 2014 at 06:00:13PM +0000, oscar.mateo@intel.com wrote:
> From: Oscar Mateo <oscar.mateo@intel.com>
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -2347,6 +2347,7 @@ int gen8_switch_context_queue(struct intel_engine *ring,
>  			      struct i915_hw_context *to,
>  			      u32 tail);
>  void gen8_handle_context_events(struct intel_engine *ring);
> +inline u32 get_submission_id(struct i915_hw_context *ctx);

More verbose warnings tell us we can't inline this function outside of
its compilation unit as its body is only accessible in i915_lrc.c. I'd
just scrap the inline here.

Also, we need to namespace that symbol.

-- 
Damien